From c585351bdc90e096b7d85c9f050151e4ecbd0702 Mon Sep 17 00:00:00 2001 From: Ackermann Yuriy <1636116+herrjemand@users.noreply.github.com> Date: Mon, 4 Sep 2023 15:31:37 +1200 Subject: [PATCH] Fixed query/instruction typoes (#10158) Fixed typoes in embedding parameters. --- libs/langchain/langchain/embeddings/deepinfra.py | 2 +- libs/langchain/langchain/embeddings/octoai_embeddings.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/langchain/langchain/embeddings/deepinfra.py b/libs/langchain/langchain/embeddings/deepinfra.py index 79d741b062d..77bfd35d61f 100644 --- a/libs/langchain/langchain/embeddings/deepinfra.py +++ b/libs/langchain/langchain/embeddings/deepinfra.py @@ -111,7 +111,7 @@ class DeepInfraEmbeddings(BaseModel, Embeddings): Returns: List of embeddings, one for each text. """ - instruction_pairs = [f"{self.query_instruction}{text}" for text in texts] + instruction_pairs = [f"{self.embed_instruction}{text}" for text in texts] embeddings = self._embed(instruction_pairs) return embeddings diff --git a/libs/langchain/langchain/embeddings/octoai_embeddings.py b/libs/langchain/langchain/embeddings/octoai_embeddings.py index c2e1711f12c..dd98f3b3354 100644 --- a/libs/langchain/langchain/embeddings/octoai_embeddings.py +++ b/libs/langchain/langchain/embeddings/octoai_embeddings.py @@ -87,4 +87,4 @@ class OctoAIEmbeddings(BaseModel, Embeddings): def embed_query(self, text: str) -> List[float]: """Compute query embedding using an OctoAI instruct model.""" text = text.replace("\n", " ") - return self._compute_embeddings([text], self.embed_instruction)[0] + return self._compute_embeddings([text], self.query_instruction)[0]