From d359b7b737180bab9dcadee6cda01a9ae7cd8bdf Mon Sep 17 00:00:00 2001 From: Michael Li Date: Tue, 3 Jun 2025 02:43:27 +1000 Subject: [PATCH] docs: fix grammar issues in airbyte_json.ipynb and airbyte_salesforce.ipynb (#31464) Thank you for contributing to LangChain! - [x] **PR title**: "package: description" - Where "package" is whichever of langchain, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes. - Example: "core: add foobar LLM" - [x] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [x] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. If no one reviews your PR within a few days, please @-mention one of baskaryan, eyurtsev, ccurme, vbarda, hwchase17. --- docs/docs/integrations/document_loaders/airbyte_json.ipynb | 4 ++-- .../integrations/document_loaders/airbyte_salesforce.ipynb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/docs/integrations/document_loaders/airbyte_json.ipynb b/docs/docs/integrations/document_loaders/airbyte_json.ipynb index 4b6d31f47c4..36622d49099 100644 --- a/docs/docs/integrations/document_loaders/airbyte_json.ipynb +++ b/docs/docs/integrations/document_loaders/airbyte_json.ipynb @@ -50,11 +50,11 @@ "\n", "5) Setup any source you wish.\n", "\n", - "6) Set destination as Local JSON, with specified destination path - lets say `/json_data`. Set up manual sync.\n", + "6) Set destination as Local JSON, with specified destination path - let's say `/json_data`. Set up manual sync.\n", "\n", "7) Run the connection.\n", "\n", - "7) To see what files are create, you can navigate to: `file:///tmp/airbyte_local`\n", + "7) To see what files are created, you can navigate to: `file:///tmp/airbyte_local`\n", "\n", "8) Find your data and copy path. That path should be saved in the file variable below. It should start with `/tmp/airbyte_local`\n" ] diff --git a/docs/docs/integrations/document_loaders/airbyte_salesforce.ipynb b/docs/docs/integrations/document_loaders/airbyte_salesforce.ipynb index fec847915cb..14fa768eb9e 100644 --- a/docs/docs/integrations/document_loaders/airbyte_salesforce.ipynb +++ b/docs/docs/integrations/document_loaders/airbyte_salesforce.ipynb @@ -138,7 +138,7 @@ "id": "4a93dc2a", "metadata": {}, "source": [ - "As `load` returns a list, it will block until all documents are loaded. To have better control over this process, you can also you the `lazy_load` method which returns an iterator instead:" + "As `load` returns a list, it will block until all documents are loaded. To have better control over this process, you can also use the `lazy_load` method which returns an iterator instead:" ] }, { @@ -156,7 +156,7 @@ "id": "3a124086", "metadata": {}, "source": [ - "Keep in mind that by default the page content is empty and the metadata object contains all the information from the record. To create documents in a different, pass in a record_handler function when creating the loader:" + "Keep in mind that by default the page content is empty and the metadata object contains all the information from the record. To create documents in a different way, pass in a record_handler function when creating the loader:" ] }, {