mirror of
https://github.com/hwchase17/langchain.git
synced 2025-09-10 23:41:28 +00:00
Fix SQLAlchemy truncating text when it is too big (#5206)
# Fixes SQLAlchemy truncating the result if you have a big/text column with many chars. SQLAlchemy truncates columns if you try to convert a Row or Sequence to a string directly For comparison: - Before: ```[('Harrison', 'That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio ... (2 characters truncated) ... hat is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio ')]``` - After: ```[('Harrison', 'That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio That is my Bio ')]``` ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: I'm not sure who to tag for chains, maybe @vowelparrot ?
This commit is contained in:
@@ -1,9 +1,18 @@
|
||||
# flake8: noqa=E501
|
||||
"""Test SQL database wrapper."""
|
||||
|
||||
from sqlalchemy import Column, Integer, MetaData, String, Table, create_engine, insert
|
||||
from sqlalchemy import (
|
||||
Column,
|
||||
Integer,
|
||||
MetaData,
|
||||
String,
|
||||
Table,
|
||||
Text,
|
||||
create_engine,
|
||||
insert,
|
||||
)
|
||||
|
||||
from langchain.sql_database import SQLDatabase
|
||||
from langchain.sql_database import SQLDatabase, truncate_word
|
||||
|
||||
metadata_obj = MetaData()
|
||||
|
||||
@@ -12,6 +21,7 @@ user = Table(
|
||||
metadata_obj,
|
||||
Column("user_id", Integer, primary_key=True),
|
||||
Column("user_name", String(16), nullable=False),
|
||||
Column("user_bio", Text, nullable=True),
|
||||
)
|
||||
|
||||
company = Table(
|
||||
@@ -32,11 +42,12 @@ def test_table_info() -> None:
|
||||
CREATE TABLE user (
|
||||
user_id INTEGER NOT NULL,
|
||||
user_name VARCHAR(16) NOT NULL,
|
||||
user_bio TEXT,
|
||||
PRIMARY KEY (user_id)
|
||||
)
|
||||
/*
|
||||
3 rows from user table:
|
||||
user_id user_name
|
||||
user_id user_name user_bio
|
||||
/*
|
||||
|
||||
|
||||
@@ -59,8 +70,8 @@ def test_table_info_w_sample_rows() -> None:
|
||||
engine = create_engine("sqlite:///:memory:")
|
||||
metadata_obj.create_all(engine)
|
||||
values = [
|
||||
{"user_id": 13, "user_name": "Harrison"},
|
||||
{"user_id": 14, "user_name": "Chase"},
|
||||
{"user_id": 13, "user_name": "Harrison", "user_bio": "bio"},
|
||||
{"user_id": 14, "user_name": "Chase", "user_bio": "bio"},
|
||||
]
|
||||
stmt = insert(user).values(values)
|
||||
with engine.begin() as conn:
|
||||
@@ -84,13 +95,14 @@ def test_table_info_w_sample_rows() -> None:
|
||||
CREATE TABLE user (
|
||||
user_id INTEGER NOT NULL,
|
||||
user_name VARCHAR(16) NOT NULL,
|
||||
user_bio TEXT,
|
||||
PRIMARY KEY (user_id)
|
||||
)
|
||||
/*
|
||||
2 rows from user table:
|
||||
user_id user_name
|
||||
13 Harrison
|
||||
14 Chase
|
||||
user_id user_name user_bio
|
||||
13 Harrison bio
|
||||
14 Chase bio
|
||||
*/
|
||||
"""
|
||||
|
||||
@@ -101,13 +113,16 @@ def test_sql_database_run() -> None:
|
||||
"""Test that commands can be run successfully and returned in correct format."""
|
||||
engine = create_engine("sqlite:///:memory:")
|
||||
metadata_obj.create_all(engine)
|
||||
stmt = insert(user).values(user_id=13, user_name="Harrison")
|
||||
stmt = insert(user).values(
|
||||
user_id=13, user_name="Harrison", user_bio="That is my Bio " * 24
|
||||
)
|
||||
with engine.begin() as conn:
|
||||
conn.execute(stmt)
|
||||
db = SQLDatabase(engine)
|
||||
command = "select user_name from user where user_id = 13"
|
||||
command = "select user_id, user_name, user_bio from user where user_id = 13"
|
||||
output = db.run(command)
|
||||
expected_output = "[('Harrison',)]"
|
||||
user_bio = "That is my Bio " * 19 + "That is my..."
|
||||
expected_output = f"[(13, 'Harrison', '{user_bio}')]"
|
||||
assert output == expected_output
|
||||
|
||||
|
||||
@@ -123,3 +138,11 @@ def test_sql_database_run_update() -> None:
|
||||
output = db.run(command)
|
||||
expected_output = ""
|
||||
assert output == expected_output
|
||||
|
||||
|
||||
def test_truncate_word() -> None:
|
||||
assert truncate_word("Hello World", length=5) == "He..."
|
||||
assert truncate_word("Hello World", length=0) == "Hello World"
|
||||
assert truncate_word("Hello World", length=-10) == "Hello World"
|
||||
assert truncate_word("Hello World", length=5, suffix="!!!") == "He!!!"
|
||||
assert truncate_word("Hello World", length=12, suffix="!!!") == "Hello World"
|
||||
|
Reference in New Issue
Block a user