github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2025-09-06 13:33:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

community[minor]: import fix (#20995)

Browse Source 
Issue: When the third-party package is not installed, whenever we need
to `pip install <package>` the ImportError is raised.
But sometimes, the `ValueError` or `ModuleNotFoundError` is raised. It
is bad for consistency.
Change: replaced the `ValueError` or `ModuleNotFoundError` with
`ImportError` when we raise an error with the `pip install <package>`
message.
Note: Ideally, we replace all `try: import... except... raise ... `with
helper functions like `import_aim` or just use the existing
[langchain_core.utils.utils.guard_import](https://api.python.langchain.com/en/latest/utils/langchain_core.utils.utils.guard_import.html#langchain_core.utils.utils.guard_import)
But it would be much bigger refactoring. @baskaryan Please, advice on
this.
This commit is contained in:
Leonid Ganeline
2024-04-29 07:32:50 -07:00
committed by GitHub
parent 2ddac9a7c3
commit dc7c06bc07
65 changed files with 103 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/community/langchain_community/embeddings/openai.py
View File

@@ -424,7 +424,7 @@ class OpenAIEmbeddings(BaseModel, Embeddings):
try:
from transformers import AutoTokenizer
except ImportError:
raise ValueError(
raise ImportError(
"Could not import transformers python package. "
"This is needed in order to for OpenAIEmbeddings without "
"`tiktoken`. Please install it with `pip install transformers`. "
@@ -557,7 +557,7 @@ class OpenAIEmbeddings(BaseModel, Embeddings):
try:
from transformers import AutoTokenizer
except ImportError:
raise ValueError(
raise ImportError(
"Could not import transformers python package. "
"This is needed in order to for OpenAIEmbeddings without "
" `tiktoken`. Please install it with `pip install transformers`."