github/langchain
1
0
Fork 0
mirror of https://github.com/hwchase17/langchain.git synced 2026-06-09 10:17:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(core,openai,anthropic): delegate to core implementation on invoke when streaming=True (#33308)

Browse Source
This commit is contained in:
ccurme
2025-10-06 15:54:55 -04:00
committed by GitHub
parent 08bf8f3dc9
commit de48e102c4
5 changed files with 15 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/partners/openai/langchain_openai/chat_models/base.py
View File

@@ -38,8 +38,6 @@ from langchain_core.language_models import LanguageModelInput
from langchain_core.language_models.chat_models import (
BaseChatModel,
LangSmithParams,
agenerate_from_stream,
generate_from_stream,
)
from langchain_core.messages import (
AIMessage,
@@ -1187,11 +1185,6 @@ class BaseChatOpenAI(BaseChatModel):
run_manager: Optional[CallbackManagerForLLMRun] = None,
**kwargs: Any,
) -> ChatResult:
if self.streaming:
stream_iter = self._stream(
messages, stop=stop, run_manager=run_manager, **kwargs
)
return generate_from_stream(stream_iter)
payload = self._get_request_payload(messages, stop=stop, **kwargs)
generation_info = None
raw_response = None
@@ -1432,11 +1425,6 @@ class BaseChatOpenAI(BaseChatModel):
run_manager: Optional[AsyncCallbackManagerForLLMRun] = None,
**kwargs: Any,
) -> ChatResult:
if self.streaming:
stream_iter = self._astream(
messages, stop=stop, run_manager=run_manager, **kwargs
)
return await agenerate_from_stream(stream_iter)
payload = self._get_request_payload(messages, stop=stop, **kwargs)
generation_info = None
raw_response = None

6
libs/partners/openai/tests/unit_tests/chat_models/test_base.py
View File

@@ -89,6 +89,12 @@ def test_openai_model_param() -> None:
assert llm.max_tokens == 10
@pytest.mark.parametrize("async_api", [True, False])
def test_streaming_attribute_should_stream(async_api: bool) -> None:
llm = ChatOpenAI(model="foo", streaming=True)
assert llm._should_stream(async_api=async_api)
def test_openai_client_caching() -> None:
"""Test that the OpenAI client is cached."""
llm1 = ChatOpenAI(model="gpt-4.1-mini")