mirror of
https://github.com/hwchase17/langchain.git
synced 2025-09-06 13:33:37 +00:00
community[patch]: More flexible handling for entity names in vector store "HANA Cloud" (#19523)
- **Description:** Added support for lower-case and mixed-case names The names for tables and columns previouly had to be UPPER_CASE. With this enhancement, also lower_case and MixedCase are supported, - **Issue:** N/A - **Dependencies:** no new dependecies added - **Twitter handle:** @sapopensource
This commit is contained in:
@@ -890,3 +890,37 @@ def test_invalid_metadata_keys(texts: List[str], metadatas: List[dict]) -> None:
|
||||
except ValueError:
|
||||
exception_occured = True
|
||||
assert exception_occured
|
||||
|
||||
|
||||
@pytest.mark.skipif(not hanadb_installed, reason="hanadb not installed")
|
||||
def test_hanavector_table_mixed_case_names(texts: List[str]) -> None:
|
||||
table_name = "MyTableName"
|
||||
content_column = "TextColumn"
|
||||
metadata_column = "MetaColumn"
|
||||
vector_column = "VectorColumn"
|
||||
|
||||
vectordb = HanaDB(
|
||||
connection=test_setup.conn,
|
||||
embedding=embedding,
|
||||
distance_strategy=DistanceStrategy.COSINE,
|
||||
table_name=table_name,
|
||||
content_column=content_column,
|
||||
metadata_column=metadata_column,
|
||||
vector_column=vector_column,
|
||||
)
|
||||
|
||||
vectordb.add_texts(texts=texts)
|
||||
|
||||
# check that embeddings have been created in the table
|
||||
number_of_texts = len(texts)
|
||||
number_of_rows = -1
|
||||
sql_str = f'SELECT COUNT(*) FROM "{table_name}"'
|
||||
cur = test_setup.conn.cursor()
|
||||
cur.execute(sql_str)
|
||||
if cur.has_result_set():
|
||||
rows = cur.fetchall()
|
||||
number_of_rows = rows[0][0]
|
||||
assert number_of_rows == number_of_texts
|
||||
|
||||
# check results of similarity search
|
||||
assert texts[0] == vectordb.similarity_search(texts[0], 1)[0].page_content
|
||||
|
Reference in New Issue
Block a user