From e92994f97307157c3536926d91f59e79b14c8220 Mon Sep 17 00:00:00 2001 From: Bagatur <22008038+baskaryan@users.noreply.github.com> Date: Wed, 27 May 2026 16:42:07 -0400 Subject: [PATCH] fix(core): drop unused type: ignore comments in lifecycle tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mypy flags the `# type: ignore[override]` on the test subclasses' `close()` / `aclose()` methods as unused — `BaseChatModel.close` / `aclose` are concrete (non-abstract) defaults, so overriding them in a subclass does not need an override suppression. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../unit_tests/language_models/chat_models/test_base.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py index 91f791294d0..5ae67f58b9c 100644 --- a/libs/core/tests/unit_tests/language_models/chat_models/test_base.py +++ b/libs/core/tests/unit_tests/language_models/chat_models/test_base.py @@ -1622,7 +1622,7 @@ async def test_base_aclose_default_dispatches_to_close() -> None: closed: list[bool] = [] class _SyncOnly(FakeListChatModel): - def close(self) -> None: # type: ignore[override] + def close(self) -> None: closed.append(True) model = _SyncOnly(responses=["x"]) @@ -1634,7 +1634,7 @@ def test_base_context_manager_calls_close() -> None: closed = [] class _Closeable(FakeListChatModel): - def close(self) -> None: # type: ignore[override] + def close(self) -> None: closed.append(True) with _Closeable(responses=["x"]) as model: @@ -1646,7 +1646,7 @@ async def test_base_async_context_manager_calls_aclose() -> None: closed = [] class _AsyncCloseable(FakeListChatModel): - async def aclose(self) -> None: # type: ignore[override] + async def aclose(self) -> None: closed.append("async") async with _AsyncCloseable(responses=["x"]) as model: