mirror of
https://github.com/hwchase17/langchain.git
synced 2025-06-22 06:39:52 +00:00
clob_bugfix... (#24813)
Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
This commit is contained in:
parent
51b15448cc
commit
f2d810b3c0
@ -601,23 +601,23 @@ class OracleVS(VectorStore):
|
|||||||
docs: List[Tuple[Any, Any, Any, Any]]
|
docs: List[Tuple[Any, Any, Any, Any]]
|
||||||
if self.insert_mode == "clob":
|
if self.insert_mode == "clob":
|
||||||
docs = [
|
docs = [
|
||||||
(id_, text, json.dumps(metadata), json.dumps(embedding))
|
(id_, json.dumps(embedding), json.dumps(metadata), text)
|
||||||
for id_, text, metadata, embedding in zip(
|
for id_, embedding, metadata, text in zip(
|
||||||
processed_ids, texts, metadatas, embeddings
|
processed_ids, embeddings, metadatas, texts
|
||||||
)
|
)
|
||||||
]
|
]
|
||||||
else:
|
else:
|
||||||
docs = [
|
docs = [
|
||||||
(id_, text, json.dumps(metadata), array.array("f", embedding))
|
(id_, array.array("f", embedding), json.dumps(metadata), text)
|
||||||
for id_, text, metadata, embedding in zip(
|
for id_, embedding, metadata, text in zip(
|
||||||
processed_ids, texts, metadatas, embeddings
|
processed_ids, embeddings, metadatas, texts
|
||||||
)
|
)
|
||||||
]
|
]
|
||||||
|
|
||||||
with self.client.cursor() as cursor:
|
with self.client.cursor() as cursor:
|
||||||
cursor.executemany(
|
cursor.executemany(
|
||||||
f"INSERT INTO {self.table_name} (id, text, metadata, "
|
f"INSERT INTO {self.table_name} (id, embedding, metadata, "
|
||||||
f"embedding) VALUES (:1, :2, :3, :4)",
|
f"text) VALUES (:1, :2, :3, :4)",
|
||||||
docs,
|
docs,
|
||||||
)
|
)
|
||||||
self.client.commit()
|
self.client.commit()
|
||||||
|
Loading…
Reference in New Issue
Block a user