mirror of
https://github.com/hwchase17/langchain.git
synced 2025-09-02 11:39:18 +00:00
Fix getattr in runnable binding for cases where config is passed in as arg too (#20528)
…s arg too Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.
This commit is contained in:
@@ -34,7 +34,14 @@ class MyRunnable(RunnableSerializable[str, str]):
|
||||
def my_custom_function(self) -> str:
|
||||
return self.my_property
|
||||
|
||||
def my_custom_function_w_config(self, config: RunnableConfig) -> str:
|
||||
def my_custom_function_w_config(
|
||||
self, config: Optional[RunnableConfig] = None
|
||||
) -> str:
|
||||
return self.my_property
|
||||
|
||||
def my_custom_function_w_kw_config(
|
||||
self, *, config: Optional[RunnableConfig] = None
|
||||
) -> str:
|
||||
return self.my_property
|
||||
|
||||
|
||||
@@ -175,7 +182,73 @@ def test_config_passthrough_nested() -> None:
|
||||
configurable={"my_property": "b"}
|
||||
).my_custom_function() # type: ignore[attr-defined]
|
||||
== "b"
|
||||
)
|
||||
), "function without config can be called w bound config"
|
||||
assert (
|
||||
configurable_runnable.with_config(
|
||||
configurable={"my_property": "b"}
|
||||
).my_custom_function_w_config( # type: ignore[attr-defined]
|
||||
)
|
||||
== "b"
|
||||
), "func with config arg can be called w bound config without config"
|
||||
assert (
|
||||
configurable_runnable.with_config(
|
||||
configurable={"my_property": "b"}
|
||||
).my_custom_function_w_config( # type: ignore[attr-defined]
|
||||
config={"configurable": {"my_property": "c"}}
|
||||
)
|
||||
== "c"
|
||||
), "func with config arg can be called w bound config with config as kwarg"
|
||||
assert (
|
||||
configurable_runnable.with_config(
|
||||
configurable={"my_property": "b"}
|
||||
).my_custom_function_w_kw_config( # type: ignore[attr-defined]
|
||||
)
|
||||
== "b"
|
||||
), "function with config kwarg can be called w bound config w/out config"
|
||||
assert (
|
||||
configurable_runnable.with_config(
|
||||
configurable={"my_property": "b"}
|
||||
).my_custom_function_w_kw_config( # type: ignore[attr-defined]
|
||||
config={"configurable": {"my_property": "c"}}
|
||||
)
|
||||
== "c"
|
||||
), "function with config kwarg can be called w bound config with config"
|
||||
assert (
|
||||
configurable_runnable.with_config(configurable={"my_property": "b"})
|
||||
.with_types()
|
||||
.my_custom_function() # type: ignore[attr-defined]
|
||||
== "b"
|
||||
), "function without config can be called w bound config"
|
||||
assert (
|
||||
configurable_runnable.with_config(configurable={"my_property": "b"})
|
||||
.with_types()
|
||||
.my_custom_function_w_config( # type: ignore[attr-defined]
|
||||
)
|
||||
== "b"
|
||||
), "func with config arg can be called w bound config without config"
|
||||
assert (
|
||||
configurable_runnable.with_config(configurable={"my_property": "b"})
|
||||
.with_types()
|
||||
.my_custom_function_w_config( # type: ignore[attr-defined]
|
||||
config={"configurable": {"my_property": "c"}}
|
||||
)
|
||||
== "c"
|
||||
), "func with config arg can be called w bound config with config as kwarg"
|
||||
assert (
|
||||
configurable_runnable.with_config(configurable={"my_property": "b"})
|
||||
.with_types()
|
||||
.my_custom_function_w_kw_config( # type: ignore[attr-defined]
|
||||
)
|
||||
== "b"
|
||||
), "function with config kwarg can be called w bound config w/out config"
|
||||
assert (
|
||||
configurable_runnable.with_config(configurable={"my_property": "b"})
|
||||
.with_types()
|
||||
.my_custom_function_w_kw_config( # type: ignore[attr-defined]
|
||||
config={"configurable": {"my_property": "c"}}
|
||||
)
|
||||
== "c"
|
||||
), "function with config kwarg can be called w bound config with config"
|
||||
# second one
|
||||
with pytest.raises(AttributeError):
|
||||
configurable_runnable.my_other_custom_function() # type: ignore[attr-defined]
|
||||
|
Reference in New Issue
Block a user