From fcf71753924f7c6cf04859ccc97ca52030e463b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20HUBSCHER?= Date: Sat, 30 Aug 2025 21:13:24 +0200 Subject: [PATCH] chore(langchain): improve PostgreSQL Manager upsert SQLAlchemy API calls. (#32748) - Make explicit the `constraint` parameter name to avoid mixing it with `index_elements` [[Documentation](https://docs.sqlalchemy.org/en/20/dialects/postgresql.html#sqlalchemy.dialects.postgresql.Insert.on_conflict_do_update)] - ~Fallback on the existing `group_id` row value, to avoid setting it to `None`.~ --- libs/langchain/langchain/indexes/_sql_record_manager.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/langchain/langchain/indexes/_sql_record_manager.py b/libs/langchain/langchain/indexes/_sql_record_manager.py index 8d24433ae4c..9c833183142 100644 --- a/libs/langchain/langchain/indexes/_sql_record_manager.py +++ b/libs/langchain/langchain/indexes/_sql_record_manager.py @@ -326,7 +326,7 @@ class SQLRecordManager(RecordManager): records_to_upsert, ) stmt = pg_insert_stmt.on_conflict_do_update( # type: ignore[assignment] - "uix_key_namespace", # Name of constraint + constraint="uix_key_namespace", # Name of constraint set_={ "updated_at": pg_insert_stmt.excluded.updated_at, "group_id": pg_insert_stmt.excluded.group_id, @@ -408,7 +408,7 @@ class SQLRecordManager(RecordManager): records_to_upsert, ) stmt = pg_insert_stmt.on_conflict_do_update( # type: ignore[assignment] - "uix_key_namespace", # Name of constraint + constraint="uix_key_namespace", # Name of constraint set_={ "updated_at": pg_insert_stmt.excluded.updated_at, "group_id": pg_insert_stmt.excluded.group_id,