mirror of
https://github.com/hwchase17/langchain.git
synced 2026-07-12 19:31:24 +00:00
fd822b07c0
## Summary - Moves `nltk`, `spacy`, `sentence-transformers`, and `konlpy` imports back inside class constructors/functions so they are only loaded when the respective splitter is actually instantiated - Adds a subprocess-based regression test to verify no heavy packages are imported at `langchain_text_splitters` load time ## Why PR #32325 moved these optional dependency imports to module-level `try/except` blocks (to satisfy ruff's `PLC0415` rule). Since `__init__.py` imports all four splitter modules, this caused `import langchain_text_splitters` to eagerly load all optional heavy packages, resulting in: - A PyTorch NVML warning (`UserWarning: Can't initialize NVML`) on non-GPU machines - A ~650MB memory spike on import (74MB → 736MB), vs ~50MB in 0.3.x The fix restores the lazy import pattern with `# noqa: PLC0415` to suppress the linter rule, which is the correct trade-off when a dependency has high instantiation cost. ## Review notes - The `PLC0415` suppressions are intentional — these are optional heavy dependencies that should never be loaded unless the user explicitly instantiates the splitter class - The regression test uses a subprocess for proper isolation (the test file itself imports `langchain_text_splitters` at the top, so `sys.modules` checks within the same process would not reflect a clean import state) Fixes #35437. > **AI disclaimer:** This PR was developed with assistance from Claude Code (Anthropic AI). --------- Co-authored-by: AshwathB-debug <ashwathbalaji04@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Mason Daugherty <github@mdrxy.com>
46 lines
1.1 KiB
Python
46 lines
1.1 KiB
Python
"""Konlpy text splitter."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
|
|
from typing_extensions import override
|
|
|
|
from langchain_text_splitters.base import TextSplitter
|
|
|
|
|
|
class KonlpyTextSplitter(TextSplitter):
|
|
"""Splitting text using Konlpy package.
|
|
|
|
It is good for splitting Korean text.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
separator: str = "\n\n",
|
|
**kwargs: Any,
|
|
) -> None:
|
|
"""Initialize the Konlpy text splitter.
|
|
|
|
Args:
|
|
separator: The separator to use when combining splits.
|
|
|
|
Raises:
|
|
ImportError: If Konlpy is not installed.
|
|
"""
|
|
super().__init__(**kwargs)
|
|
self._separator = separator
|
|
try:
|
|
import konlpy # noqa: PLC0415
|
|
except ImportError as err:
|
|
msg = (
|
|
"Konlpy is not installed, please install it with `pip install konlpy`."
|
|
)
|
|
raise ImportError(msg) from err
|
|
self.kkma = konlpy.tag.Kkma()
|
|
|
|
@override
|
|
def split_text(self, text: str) -> list[str]:
|
|
splits = self.kkma.sentences(text)
|
|
return self._merge_splits(splits, self._separator)
|