Really Him 918c950737 DOCS: partners/chroma: Fix documentation around chroma query filter syntax (#31058) ... Thank you for contributing to LangChain! - [x] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" **Description**: * Starting to put together some PR's to fix the typing around `langchain-chroma` `filter` and `where_document` query filtering, as mentioned: https://github.com/langchain-ai/langchain/issues/30879 https://github.com/langchain-ai/langchain/issues/30507 The typing of `dict[str, str]` is on the one hand too restrictive (marks valid filter expressions as ill-typed) and also too permissive (allows illegal filter expressions). That's not what this PR addresses though. This PR just removes from the documentation some examples of filters that are illegal, and also syntactically incorrect: (a) dictionaries with keys like `$contains` but the key is missing quotation marks; (b) dictionaries with multiple entries - this is illegal in Chroma filter syntax and will raise an exception. (`{"foo": "bar", "qux": "baz"}`). Filter dictionaries in Chroma must have one and one key only. Again this is just the documentation issue, which is the lowest hanging fruit. I also think we need to update the types for `filter` and `where_document` to be (at the very least `dict[str, Any]`), or, since we have access to Chroma's types, they should be `Where` and `WhereDocument` types. This has a wider blast radius though, so I'm starting small. This PR does not fix the issues mentioned above, it's just starting to get the ball rolling, and cleaning up the documentation. - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, eyurtsev, ccurme, vbarda, hwchase17. --------- Co-authored-by: Really Him <hesereallyhim@proton.me>		2025-04-30 17:51:07 -04:00
..
__init__.py	infra: update mypy 1.10, ruff 0.5 (#23721)	2024-07-03 10:33:27 -07:00
py.typed
vectorstores.py	DOCS: partners/chroma: Fix documentation around chroma query filter syntax (#31058)	2025-04-30 17:51:07 -04:00