mirror of
https://github.com/hwchase17/langchain.git
synced 2026-02-21 14:43:07 +00:00
0dd2c21089
Using `poetry add` to install `pydantic@2.1` was also causing poetry to change its lockfile. This prevented dependency caching from working: - When attempting to restore a cache, it would hash the lockfile in git and use it as part of the cache key. Say this is a cache miss. - Then, it would attempt to save the cache -- but the lockfile will have changed, so the cache key would be *different* than the key in the lookup. So the cache save would succeed, but to a key that cannot be looked up in the next run -- meaning we never get a cache hit. In addition to busting the cache, the lockfile update itself is also non-trivially long, over 30s:  This PR fixes the problems by using `pip` to perform the installation, avoiding the lockfile change.
89 lines
3.0 KiB
YAML
89 lines
3.0 KiB
YAML
name: test
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
working-directory:
|
|
required: true
|
|
type: string
|
|
description: "From which folder this pipeline executes"
|
|
test_type:
|
|
type: string
|
|
description: "Test types to run"
|
|
default: '["core", "extended", "core-pydantic-2"]'
|
|
|
|
env:
|
|
POETRY_VERSION: "1.4.2"
|
|
|
|
jobs:
|
|
build:
|
|
defaults:
|
|
run:
|
|
working-directory: ${{ inputs.working-directory }}
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
python-version:
|
|
- "3.8"
|
|
- "3.9"
|
|
- "3.10"
|
|
- "3.11"
|
|
test_type: ${{ fromJSON(inputs.test_type) }}
|
|
name: Python ${{ matrix.python-version }} ${{ matrix.test_type }}
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
- name: Set up Python ${{ matrix.python-version }}
|
|
uses: "./.github/actions/poetry_setup"
|
|
with:
|
|
python-version: ${{ matrix.python-version }}
|
|
working-directory: ${{ inputs.working-directory }}
|
|
poetry-version: "1.4.2"
|
|
cache-key: ${{ matrix.test_type }}
|
|
install-command: |
|
|
if [ "${{ matrix.test_type }}" == "core" ]; then
|
|
echo "Running core tests, installing dependencies with poetry..."
|
|
poetry install
|
|
elif [ "${{ matrix.test_type }}" == "core-pydantic-2" ]; then
|
|
echo "Running core-pydantic-v2 tests, installing dependencies with poetry..."
|
|
poetry install
|
|
|
|
# Install via `pip` instead of `poetry add` to avoid changing lockfile,
|
|
# which would prevent caching from working: the cache would get saved
|
|
# to a different key than where it gets loaded from.
|
|
poetry run pip install 'pydantic>=2.1,<3'
|
|
else
|
|
echo "Running extended tests, installing dependencies with poetry..."
|
|
poetry install -E extended_testing
|
|
fi
|
|
- name: Verify pydantic version
|
|
run: |
|
|
if [ "${{ matrix.test_type }}" == "core-pydantic-2" ]; then
|
|
EXPECTED_VERSION=2
|
|
else
|
|
EXPECTED_VERSION=1
|
|
fi
|
|
echo "Checking pydantic version... Expecting ${EXPECTED_VERSION}"
|
|
|
|
# Determine the major part of pydantic version
|
|
VERSION=$(poetry run python -c "import pydantic; print(pydantic.__version__)" | cut -d. -f1)
|
|
|
|
# Check that the major part of pydantic version is as expected, if not
|
|
# raise an error
|
|
if [[ "$VERSION" -ne $EXPECTED_VERSION ]]; then
|
|
echo "Error: pydantic version must be equal to ${EXPECTED_VERSION}; Found: ${VERSION}"
|
|
exit 1
|
|
fi
|
|
echo "Found pydantic version ${VERSION}, as expected"
|
|
shell: bash
|
|
- name: Run ${{matrix.test_type}} tests
|
|
run: |
|
|
case "${{ matrix.test_type }}" in
|
|
core | core-pydantic-2)
|
|
make test
|
|
;;
|
|
*)
|
|
make extended_tests
|
|
;;
|
|
esac
|
|
shell: bash
|