mirror of
https://github.com/hwchase17/langchain.git
synced 2026-05-07 03:59:39 +00:00
Hi, this PR enables configuring the html2text package, instead of being
bound to use the hardcoded values. While simply passing `ignore_links`
and `ignore_images` to the `transform_documents` method was possible, I
preferred passing them to the `__init__` method for 2 reasons:
1. It is more efficient in case of subsequent calls to
`transform_documents`.
2. It allows to move the "complexity" to the instantiation, keeping the
actual execution simple and general enough. IMO the transformers should
all follow this pattern, allowing something like this:
```python
# Instantiate transformers
transformers = [
TransformerA(foo='bar'),
TransformerB(bar='foo'),
# others
]
# During execution, call them sequentially
documents = ...
for tr in transformers:
documents = tr.transform_documents(documents)
```
Thanks for the reviews!
---------
Co-authored-by: taamedag <Davide.Menini@swisscom.com>