mirror of
https://github.com/hwchase17/langchain.git
synced 2025-10-22 09:41:52 +00:00
fca1aaa9b5
# Description This PR fixes a bug in _recursive_set_additional_properties_false used in function_calling.convert_to_openai_function. Previously, schemas with "additionalProperties=True" were not correctly overridden when strict validation was expected, which could lead to invalid OpenAI function schemas. The updated implementation ensures that: - Any schema with "additionalProperties" already set will now be forced to False under strict mode. - Recursive traversal of properties, items, and anyOf is preserved. - Function signature remains unchanged for backward compatibility. # Issue When using tool calling in OpenAI structured output strict mode (strict=True), 400: "Invalid schema for response_format XXXXX 'additionalProperties' is required to be supplied and to be false" error raises for the parameter that contains dict type. OpenAI requires additionalProperties to be set to False. Some PRs try to resolved the issue. - PR #25169 introduced _recursive_set_additional_properties_false to recursively set additionalProperties=False. - PR #26287 fixed handling of empty parameter tools for OpenAI function generation. - PR #30971 added support for Union type arguments in strict mode of OpenAI function calling / structured output. Despite these improvements, since Pydantic 2.11, it will always add `additionalProperties: True` for arbitrary dictionary schemas dict or Any (https://pydantic.dev/articles/pydantic-v2-11-release#changes). Schemas that already had additionalProperties=True in such cases were not being overridden, which this PR addresses to ensure strict mode behaves correctly in all cases. # Dependencies No Changes --------- Co-authored-by: Zhong, Yu <yzhong@freewheel.com>