From 7276b19a928d0f8115a3e8fcfa97c72b8e1116f3 Mon Sep 17 00:00:00 2001
From: ibuler <ibuler@qq.com>
Date: Wed, 31 May 2023 16:16:13 +0800
Subject: [PATCH] =?UTF-8?q?perf:=20=E4=BC=98=E5=8C=96=20nest=20fields=20?=
 =?UTF-8?q?=E6=94=AF=E6=8C=81=E6=98=AF=E5=90=A6=E9=9A=90=E8=97=8F?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/components/AutoDataForm/utils.js          |   4 +
 .../CommandFilterCreateUpdate.vue             |  98 --------------
 .../CommandFilterDetail/Detail.vue            | 122 ------------------
 .../CommandFilterDetail/Rules.vue             |  74 -----------
 .../CommandFilterDetail/RulesCreateUpdate.vue | 100 --------------
 .../CommandFilterDetail/index.vue             |  45 -------
 .../CommandFilter/CommandFilterList.vue       |  97 --------------
 .../assets/Platform/PlatformDetail/Detail.vue |   3 +-
 8 files changed, 6 insertions(+), 537 deletions(-)
 delete mode 100644 src/views/assets/CommandFilter/CommandFilterCreateUpdate.vue
 delete mode 100644 src/views/assets/CommandFilter/CommandFilterDetail/Detail.vue
 delete mode 100644 src/views/assets/CommandFilter/CommandFilterDetail/Rules.vue
 delete mode 100644 src/views/assets/CommandFilter/CommandFilterDetail/RulesCreateUpdate.vue
 delete mode 100644 src/views/assets/CommandFilter/CommandFilterDetail/index.vue
 delete mode 100644 src/views/assets/CommandFilter/CommandFilterList.vue

diff --git a/src/components/AutoDataForm/utils.js b/src/components/AutoDataForm/utils.js
index 9aa6517a7..6da1ca7c3 100644
--- a/src/components/AutoDataForm/utils.js
+++ b/src/components/AutoDataForm/utils.js
@@ -85,6 +85,10 @@ export class FormFieldGenerator {
         field.el = { ...field.el, ...fieldMeta }
         field.el.fields = this.generateNestFields(field, fieldMeta, fieldRemoteMeta)
         field.el.errors = {}
+        field.hidden = () => {
+          const hidden = fieldMeta['hiddenFields'] || (() => field.el.fields.length === 0)
+          return hidden(fieldMeta, fieldRemoteMeta, field.el.fields)
+        }
         break
       default:
         type = 'input'
diff --git a/src/views/assets/CommandFilter/CommandFilterCreateUpdate.vue b/src/views/assets/CommandFilter/CommandFilterCreateUpdate.vue
deleted file mode 100644
index 2777fe225..000000000
--- a/src/views/assets/CommandFilter/CommandFilterCreateUpdate.vue
+++ /dev/null
@@ -1,98 +0,0 @@
-<template>
-  <GenericCreateUpdatePage :fields="fields" :initial="initial" :fields-meta="fieldsMeta" :url="url" />
-</template>
-
-<script>
-import GenericCreateUpdatePage from '@/layout/components/GenericCreateUpdatePage'
-import AssetSelect from '@/components/AssetSelect/index'
-export default {
-  name: 'CommandFilterCreateUpdate',
-  components: { GenericCreateUpdatePage },
-  data() {
-    return {
-      initial: {
-
-      },
-      fields: [
-        [this.$t('common.Basic'), ['name']],
-        [this.$t('common.Correlation'), ['users', 'user_groups', 'nodes', 'assets', 'applications', 'system_users']],
-        [this.$t('common.Other'), ['is_active', 'comment']]
-      ],
-      fieldsMeta: {
-        users: {
-          el: {
-            value: [],
-            ajax: {
-              url: '/api/v1/users/users/?fields_size=mini',
-              transformOption: (item) => {
-                return { label: item.name + '(' + item.username + ')', value: item.id }
-              }
-            }
-          }
-        },
-        user_groups: {
-          el: {
-            value: [],
-            url: '/api/v1/users/groups/'
-          }
-        },
-        nodes: {
-          el: {
-            value: [],
-            ajax: {
-              url: '/api/v1/assets/nodes/',
-              transformOption: (item) => {
-                return { label: item.full_value, value: item.id }
-              }
-            }
-          }
-        },
-        assets: {
-          type: 'assetSelect',
-          component: AssetSelect,
-          label: this.$t('perms.Asset'),
-          rules: [{
-            required: false
-          }],
-          el: {
-            value: []
-          }
-        },
-        applications: {
-          label: this.$t('assets.Applications'),
-          el: {
-            value: [],
-            ajax: {
-              url: `/api/v1/applications/applications/?category__in=db,cloud`,
-              transformOption: (item) => {
-                return { label: item.name + ' (' + item.type_display + ')', value: item.id }
-              }
-            }
-          }
-        },
-        system_users: {
-          el: {
-            value: [],
-            ajax: {
-              url: `/api/v1/assets/system-users/?protocol__in=ssh,telnet,mysql,postgresql,mariadb,oracle,sqlserver,k8s,redis,mongodb,clickhouse`,
-              transformOption: (item) => {
-                if (this.$route.query.type === 'k8s') {
-                  return { label: item.name, value: item.id }
-                }
-                const username = item.username || '*'
-                return { label: item.name + '(' + username + ')', value: item.id }
-              }
-            }
-          }
-        }
-
-      },
-      url: '/api/v1/assets/cmd-filters/'
-    }
-  }
-}
-</script>
-
-<style lang='less' scoped>
-
-</style>
diff --git a/src/views/assets/CommandFilter/CommandFilterDetail/Detail.vue b/src/views/assets/CommandFilter/CommandFilterDetail/Detail.vue
deleted file mode 100644
index a1b69f777..000000000
--- a/src/views/assets/CommandFilter/CommandFilterDetail/Detail.vue
+++ /dev/null
@@ -1,122 +0,0 @@
-<template>
-  <el-row :gutter="20">
-    <el-col :md="14" :sm="24">
-      <AutoDetailCard :url="url" :object="object" />
-    </el-col>
-    <el-col :md="10" :sm="24">
-      <RelationCard ref="users" v-bind="userRelationConfig" />
-      <RelationCard ref="userGroups" type="info" v-bind="userGroupsRelationConfig" class="card-margin" />
-      <RelationCard ref="applications" type="warning" v-bind="applicationsRelationConfig" class="card-margin" />
-      <RelationCard ref="systemUsers" type="danger" v-bind="systemUserRelationConfig" class="card-margin" />
-    </el-col>
-  </el-row>
-</template>
-
-<script>
-import AutoDetailCard from '@/components/DetailCard/auto'
-import RelationCard from '@/components/RelationCard'
-export default {
-  name: 'Detail',
-  components: {
-    AutoDetailCard,
-    RelationCard
-  },
-  props: {
-    object: {
-      type: Object,
-      default: () => {}
-    }
-  },
-  data() {
-    const disabled = !this.$hasPerm('assets.change_commandfilter')
-    const defaultTransformOption = (item, filed) => {
-      const currentFiled = item[filed] ? item[filed] : filed === 'username' ? '*' : ''
-      return { label: item.name + '(' + currentFiled + ')', value: item.id }
-    }
-    return {
-      userRelationConfig: {
-        disabled,
-        icon: 'fa-user',
-        title: this.$t('common.User'),
-        objectsAjax: {
-          url: '/api/v1/users/users/?fields_size=mini',
-          transformOption: (item) => defaultTransformOption(item, 'username')
-        },
-        hasObjectsId: this.object.users,
-        performAdd: item => this.performAddHandle(item, 'users'),
-        performDelete: item => this.performDeleteHandle(item, 'users')
-      },
-      userGroupsRelationConfig: {
-        disabled,
-        icon: 'fa-users',
-        title: this.$t('users.UserGroups'),
-        objectsAjax: {
-          url: '/api/v1/users/groups/'
-        },
-        hasObjectsId: this.object.user_groups,
-        performAdd: item => this.performAddHandle(item, 'user_groups'),
-        performDelete: item => this.performDeleteHandle(item, 'user_groups')
-      },
-      applicationsRelationConfig: {
-        disabled,
-        icon: 'fa-th',
-        title: this.$t('assets.Applications'),
-        objectsAjax: {
-          url: `/api/v1/applications/applications/?category__in=db,cloud`,
-          transformOption: (item) => defaultTransformOption(item, 'type_display')
-        },
-        hasObjectsId: this.object.applications,
-        performAdd: item => this.performAddHandle(item, 'applications'),
-        performDelete: item => this.performDeleteHandle(item, 'applications')
-      },
-      systemUserRelationConfig: {
-        disabled,
-        icon: 'fa-info-circle',
-        title: this.$t('assets.SystemUser'),
-        objectsAjax: {
-          url: `/api/v1/assets/system-users/?protocol__in=ssh,telnet,mysql,postgresql,mariadb,oracle,sqlserver,k8s,redis,mongodb,clickhouse`,
-          transformOption: (item) => defaultTransformOption(item, 'username')
-        },
-        hasObjectsId: this.object.system_users,
-        performAdd: item => this.performAddHandle(item, 'system_users'),
-        performDelete: item => this.performDeleteHandle(item, 'system_users')
-      },
-      url: '/api/v1/assets/cmd-filters/'
-    }
-  },
-  computed: {
-  },
-  methods: {
-    performAddHandle(item, updateField) {
-      const newDatas = []
-      const updateFieldRef = _.camelCase(updateField)
-      const options = this.$refs[updateFieldRef].iHasObjects
-      const relationUrl = `/api/v1/assets/cmd-filters/${this.object.id}/`
-      options.forEach(v => newDatas.push(v.value))
-      item.forEach(v => newDatas.push(v.value))
-
-      return this.$axios.patch(relationUrl, { [updateField]: newDatas })
-    },
-    performDeleteHandle(item, updateField) {
-      const newDatas = []
-      const itemId = item?.value || ''
-      const updateFieldRef = _.camelCase(updateField)
-      const options = this.$refs[updateFieldRef].iHasObjects
-      const relationUrl = `/api/v1/assets/cmd-filters/${this.object.id}/`
-      options.forEach(v => {
-        if (v.value !== itemId) {
-          newDatas.push(v.value)
-        }
-      })
-
-      return this.$axios.patch(relationUrl, { [updateField]: newDatas })
-    }
-  }
-}
-</script>
-
-<style lang='less' scoped>
-  .card-margin {
-    margin-top: 15px;
-  }
-</style>
diff --git a/src/views/assets/CommandFilter/CommandFilterDetail/Rules.vue b/src/views/assets/CommandFilter/CommandFilterDetail/Rules.vue
deleted file mode 100644
index 0dae1b636..000000000
--- a/src/views/assets/CommandFilter/CommandFilterDetail/Rules.vue
+++ /dev/null
@@ -1,74 +0,0 @@
-<template>
-  <GenericListTable :table-config="tableConfig" :header-actions="headerActions" />
-</template>
-
-<script>
-import GenericListTable from '@/layout/components/GenericListTable'
-
-export default {
-  name: 'Rules',
-  components: {
-    GenericListTable
-  },
-  props: {
-    object: {
-      type: Object,
-      default: () => {}
-    }
-  },
-  data() {
-    return {
-      tableConfig: {
-        url: `/api/v1/assets/cmd-filters/${this.object.id}/rules/`,
-        permissions: {
-          resource: 'commandfilterrule'
-        },
-        columns: ['type', 'content', 'ignore_case', 'action', 'priority', 'pattern', 'comment', 'actions'],
-        columnsMeta: {
-          type: {
-            width: '100px'
-          },
-          ignore_case: {
-            width: '100px',
-            formatterArgs: {
-              showFalse: false
-            }
-          },
-          priority: {
-            width: '70px'
-          },
-          action: {
-            width: '90px'
-          },
-          actions: {
-            formatterArgs: {
-              hasClone: false,
-              updateRoute: {
-                name: 'CommandFilterRulesUpdate',
-                query: {
-                  filter: this.object.id
-                }
-              }
-            }
-          }
-        }
-      },
-      headerActions: {
-        hasSearch: true,
-        hasBulkDelete: false,
-        hasMoreActions: false,
-        createRoute: {
-          name: 'CommandFilterRulesCreate',
-          query: {
-            filter: this.object.id
-          }
-        }
-      }
-    }
-  }
-}
-</script>
-
-<style lang='less' scoped>
-
-</style>
diff --git a/src/views/assets/CommandFilter/CommandFilterDetail/RulesCreateUpdate.vue b/src/views/assets/CommandFilter/CommandFilterDetail/RulesCreateUpdate.vue
deleted file mode 100644
index 1eaf34806..000000000
--- a/src/views/assets/CommandFilter/CommandFilterDetail/RulesCreateUpdate.vue
+++ /dev/null
@@ -1,100 +0,0 @@
-<template>
-  <GenericCreateUpdatePage
-    :fields="fields"
-    :initial="initial"
-    :fields-meta="fieldsMeta"
-    :url="url"
-    :has-detail-in-msg="false"
-    :get-next-route="getNextRoute"
-  />
-</template>
-
-<script>
-import GenericCreateUpdatePage from '@/layout/components/GenericCreateUpdatePage'
-import Select2 from '@/components/FormFields/Select2'
-import rules from '@/components/DataForm/rules'
-export default {
-  name: 'RulesCreateUpdate',
-  components: { GenericCreateUpdatePage },
-  data() {
-    const filterId = this.$route.query.filter || '00000000-0000-0000-0000-000000000000'
-    const regexPlaceholder = 'rm.*|reboot|shutdown'
-    const commandPlaceholder = 'rm\rreboot'
-    const commandHelpText = this.$t('assets.CommandFilterRuleContentHelpText')
-    const vm = this
-    return {
-      initial: {
-        filter: filterId,
-        type: 'regex',
-        action: 0
-      },
-      fields: [
-        [this.$t('common.Basic'), ['filter', 'type', 'content', 'ignore_case', 'priority', 'action', 'reviewers', 'comment']]
-      ],
-      fieldsMeta: {
-        filter: {
-          component: Select2,
-          el: {
-            ajax: {
-              url: '/api/v1/assets/cmd-filters/'
-            },
-            disabled: true,
-            multiple: false
-          }
-        },
-        type: {
-          on: {
-            change: ([val]) => {
-              if (val === 'command') {
-                vm.fieldsMeta.content.el.placeholder = commandPlaceholder
-                vm.fieldsMeta.content.helpText = commandHelpText
-              } else {
-                vm.fieldsMeta.content.el.placeholder = regexPlaceholder
-                vm.fieldsMeta.content.helpText = ''
-              }
-            }
-          }
-        },
-        content: {
-          type: 'input',
-          el: {
-            type: 'textarea',
-            placeholder: 'rm.*|reboot|shutdown',
-            rows: 4
-          },
-          helpText: ''
-        },
-        reviewers: {
-          hidden: (item) => item.action !== 2,
-          rules: [rules.RequiredChange],
-          el: {
-            value: [],
-            ajax: {
-              url: '/api/v1/users/users/?fields_size=mini',
-              transformOption: (item) => {
-                return { label: item.name + '(' + item.username + ')', value: item.id }
-              }
-            }
-          }
-        }
-      },
-      getNextRoute(res, method) {
-        return {
-          name: 'CommandFilterDetail',
-          params: {
-            id: res.filter
-          },
-          query: {
-            activeTable: 'rules'
-          }
-        }
-      },
-      url: `/api/v1/assets/cmd-filters/${filterId}/rules/`
-    }
-  }
-}
-</script>
-
-<style lang='less' scoped>
-
-</style>
diff --git a/src/views/assets/CommandFilter/CommandFilterDetail/index.vue b/src/views/assets/CommandFilter/CommandFilterDetail/index.vue
deleted file mode 100644
index bc5523b64..000000000
--- a/src/views/assets/CommandFilter/CommandFilterDetail/index.vue
+++ /dev/null
@@ -1,45 +0,0 @@
-<template>
-  <GenericDetailPage :object.sync="TaskDetail" :active-menu.sync="config.activeMenu" v-bind="config" v-on="$listeners">
-    <keep-alive>
-      <component :is="config.activeMenu" :object="TaskDetail" />
-    </keep-alive>
-  </GenericDetailPage>
-</template>
-
-<script>
-import { GenericDetailPage, TabPage } from '@/layout/components'
-import Detail from './Detail.vue'
-import Rules from './Rules.vue'
-export default {
-  components: {
-    GenericDetailPage,
-    TabPage,
-    Detail,
-    Rules
-  },
-  data() {
-    return {
-      TaskDetail: {},
-      config: {
-        activeMenu: 'Detail',
-        submenu: [
-          {
-            title: this.$t('assets.CommandFilterDetail'),
-            name: 'Detail'
-          },
-          {
-            title: this.$t('assets.CommandFilterRules'),
-            name: 'rules',
-            hidden: () => !this.$hasPerm('assets.view_commandfilterrule')
-          }
-        ],
-        hasRightSide: true
-      }
-    }
-  }
-}
-</script>
-
-<style scoped>
-
-</style>
diff --git a/src/views/assets/CommandFilter/CommandFilterList.vue b/src/views/assets/CommandFilter/CommandFilterList.vue
deleted file mode 100644
index 2d7d3430c..000000000
--- a/src/views/assets/CommandFilter/CommandFilterList.vue
+++ /dev/null
@@ -1,97 +0,0 @@
-<template>
-  <GenericListPage :table-config="tableConfig" :header-actions="headerActions" :help-message="title" />
-</template>
-
-<script>
-import { GenericListPage } from '@/layout/components'
-import { DetailFormatter } from '@/components/TableFormatters'
-
-export default {
-  components: {
-    GenericListPage
-  },
-  data() {
-    return {
-      tableConfig: {
-        url: '/api/v1/assets/cmd-filters/',
-        permissions: {
-          app: 'assets',
-          resource: 'commandfilter'
-        },
-        columns: [
-          'name', 'rules', 'users', 'user_groups', 'assets', 'applications', 'system_users', 'is_active',
-          'created_by', 'date_created', 'comment', 'org_name', 'actions'
-        ],
-        columnsShow: {
-          min: ['name', 'actions'],
-          default: ['name', 'rules', 'comment', 'actions']
-        },
-        columnsMeta: {
-          rules: {
-            label: this.$t('assets.Rules'),
-            formatter: DetailFormatter,
-            formatterArgs: {
-              getTitle: ({ cellValue }) => {
-                return cellValue.length
-              },
-              routeQuery: {
-                activeTab: 'rules'
-              }
-            }
-          },
-          date_created: {
-            label: this.$t('users.DateJoined')
-          },
-          users: {
-            formatter: function(row, col, cell) {
-              return cell.length
-            }
-          },
-          user_groups: {
-            formatter: function(row, col, cell) {
-              return cell.length
-            }
-          },
-          assets: {
-            formatter: function(row, col, cell) {
-              return cell.length
-            }
-          },
-          applications: {
-            formatter: function(row, col, cell) {
-              return cell.length
-            }
-          },
-          system_users: {
-            label: this.$t('assets.SystemUsers'),
-            formatter: DetailFormatter,
-            formatterArgs: {
-              route: 'CommandFilterDetail',
-              getTitle: ({ cellValue }) => {
-                return cellValue.length
-              }
-            }
-          }
-        }
-      },
-      headerActions: {
-        hasRightActions: true,
-        hasExport: false,
-        hasImport: false,
-        hasRefresh: true,
-        hasSearch: true,
-        createRoute: 'CommandFilterCreate'
-      }
-    }
-  },
-  computed: {
-    title() {
-      return this.$t('assets.CommandFilterHelpMessage')
-    }
-  }
-}
-</script>
-
-<style>
-
-</style>
diff --git a/src/views/assets/Platform/PlatformDetail/Detail.vue b/src/views/assets/Platform/PlatformDetail/Detail.vue
index 78507dde8..826a2154e 100644
--- a/src/views/assets/Platform/PlatformDetail/Detail.vue
+++ b/src/views/assets/Platform/PlatformDetail/Detail.vue
@@ -66,7 +66,8 @@ export default {
           key: this.$t('assets.Type'),
           value: `${this.object.category?.label}/${this.object.type?.label}`
         },
-        'su_method', 'comment'
+        'su_method', 'date_created', 'date_updated',
+        'created_by', 'updated_by', 'comment'
       ],
 
       protocolChoices: null,