From aa00f1e4a6e6b78dec047315aad6858278693173 Mon Sep 17 00:00:00 2001 From: fit2bot <68588906+fit2bot@users.noreply.github.com> Date: Tue, 17 May 2022 15:16:33 +0800 Subject: [PATCH] =?UTF-8?q?perf:=20=E4=BF=AE=E6=94=B9=20console.log()=20?= =?UTF-8?q?=E8=AF=AD=E5=8F=A5=E4=B8=BA=20debug()=20=E6=A0=87=E8=AF=86=20(#?= =?UTF-8?q?1749)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jiangjie.Bai Co-authored-by: Jiangjie.Bai <32935519+BaiJiangJie@users.noreply.github.com> --- build/index.js | 4 ++-- mock/index.js | 2 +- mock/mock-server.js | 4 ++-- src/components/CronTab/Crontab.vue | 2 +- src/components/CronTab/components/Crontab-Result.vue | 2 +- .../DataForm/components/el-form-renderer/el-form-renderer.vue | 2 +- src/components/DataForm/index.vue | 2 +- src/components/DataZTree/index.vue | 2 +- src/components/ListTable/TableAction/ImportDialog.vue | 3 ++- src/components/ListTable/TableAction/utils.js | 2 +- src/components/TableFormatters/DateFormatter.vue | 2 +- src/components/TreeTable/index.vue | 2 +- src/guards.js | 2 +- src/store/modules/permission.js | 2 +- src/store/modules/users.js | 2 +- src/utils/request.js | 4 ++-- src/views/assets/Asset/TreeMenu.vue | 2 +- src/views/login/index.vue | 2 +- src/views/settings/Message/index.vue | 4 ++-- tests/unit/components/Breadcrumb.spec.js | 2 +- 20 files changed, 25 insertions(+), 24 deletions(-) diff --git a/build/index.js b/build/index.js index 0c57de2aa..f71ba20fe 100644 --- a/build/index.js +++ b/build/index.js @@ -24,9 +24,9 @@ if (process.env.npm_config_preview || rawArgv.includes('--preview')) { ) app.listen(port, function () { - console.log(chalk.green(`> Preview at http://localhost:${port}${publicPath}`)) + // debug(chalk.green(`> Preview at http://localhost:${port}${publicPath}`)) if (report) { - console.log(chalk.green(`> Report at http://localhost:${port}${publicPath}report.html`)) + // debug(chalk.green(`> Report at http://localhost:${port}${publicPath}report.html`)) } }) diff --git a/mock/index.js b/mock/index.js index 90e2ffe9e..d43958fd3 100644 --- a/mock/index.js +++ b/mock/index.js @@ -56,7 +56,7 @@ const responseFake = (url, type, respond) => { url: new RegExp(`${process.env.VUE_APP_BASE_API}${url}`), type: type || 'get', response(req, res) { - console.log('request invoke:' + req.path) + // debug('request invoke:' + req.path) res.json(Mock.mock(respond instanceof Function ? respond(req, res) : respond)) } } diff --git a/mock/mock-server.js b/mock/mock-server.js index 4c4cb2af8..8393f84c5 100644 --- a/mock/mock-server.js +++ b/mock/mock-server.js @@ -59,9 +59,9 @@ module.exports = app => { mockRoutesLength = mockRoutes.mockRoutesLength mockStartIndex = mockRoutes.mockStartIndex - console.log(chalk.magentaBright(`\n > Mock Server hot reload success! changed ${path}`)) + // debug(chalk.magentaBright(`\n > Mock Server hot reload success! changed ${path}`)) } catch (error) { - console.log(chalk.redBright(error)) + // debug(chalk.redBright(error)) } } }) diff --git a/src/components/CronTab/Crontab.vue b/src/components/CronTab/Crontab.vue index ff82a5b55..2d1bc4b16 100644 --- a/src/components/CronTab/Crontab.vue +++ b/src/components/CronTab/Crontab.vue @@ -238,7 +238,7 @@ export default { updateContabValue(name, value, from) { this.contabValueObj[name] = value if (from && from !== name) { - console.log(`来自组件 ${from} 改变了 ${name} ${value}`) + // debug(`来自组件 ${from} 改变了 ${name} ${value}`) this.changeRadio(name, value) } }, diff --git a/src/components/CronTab/components/Crontab-Result.vue b/src/components/CronTab/components/Crontab-Result.vue index f77c7ed54..768dae35d 100644 --- a/src/components/CronTab/components/Crontab-Result.vue +++ b/src/components/CronTab/components/Crontab-Result.vue @@ -53,7 +53,7 @@ export default { } } catch (error) { this.isShow = false - console.log(error, 'error') + // debug(error, 'error') } } } diff --git a/src/components/DataForm/components/el-form-renderer/el-form-renderer.vue b/src/components/DataForm/components/el-form-renderer/el-form-renderer.vue index 3737a89ab..9e3a7d543 100755 --- a/src/components/DataForm/components/el-form-renderer/el-form-renderer.vue +++ b/src/components/DataForm/components/el-form-renderer/el-form-renderer.vue @@ -146,7 +146,7 @@ export default { * - el-form 的 resetFields 不会触发 input & change 事件，无法监听 * - bug1: https://github.com/FEMessage/el-data-table/issues/176#issuecomment-587280825 * - bug2: - * 0. 建议先在监听器 watch.value 里 console.log(v.name, oldV.name) + * 0. 建议先在监听器 watch.value 里 // debug(v.name, oldV.name) * 1. 打开 basic 示例 * 2. 在 label 为 name 的输入框里输入 1，此时 log：'1' '' * 3. 点击 reset 按钮，此时 log 两条数据： '1' '1', '' '' diff --git a/src/components/DataForm/index.vue b/src/components/DataForm/index.vue index 4472e48dc..0c211defc 100644 --- a/src/components/DataForm/index.vue +++ b/src/components/DataForm/index.vue @@ -97,7 +97,7 @@ export default { }, handleClick(button) { const callback = button.callback || function(values, form) { - // console.log('Click ', button.title, ': ', values) + // debug('Click ', button.title, ': ', values) } const form = this.$refs['form'] const values = form.getFormValue() diff --git a/src/components/DataZTree/index.vue b/src/components/DataZTree/index.vue index f96f8d256..9b3d40825 100644 --- a/src/components/DataZTree/index.vue +++ b/src/components/DataZTree/index.vue @@ -72,7 +72,7 @@ export default { }, methods: { defaultCallback: function(action) { - // console.log(action) + // debug(action) } } } diff --git a/src/components/ListTable/TableAction/ImportDialog.vue b/src/components/ListTable/TableAction/ImportDialog.vue index 2b5319fb7..bb610c838 100644 --- a/src/components/ListTable/TableAction/ImportDialog.vue +++ b/src/components/ListTable/TableAction/ImportDialog.vue @@ -205,8 +205,9 @@ export default { } return this.url.indexOf('?') === -1 ? `${this.url}?${query}` : `${this.url}&${query}` }, + // eslint-disable-next-line handle-callback-err catchError(error) { - console.log(error) + // debug(error) }, onSuccess(msg) { this.errorMsg = '' diff --git a/src/components/ListTable/TableAction/utils.js b/src/components/ListTable/TableAction/utils.js index 46626235d..fb56402cb 100644 --- a/src/components/ListTable/TableAction/utils.js +++ b/src/components/ListTable/TableAction/utils.js @@ -1,5 +1,5 @@ export function cleanActions(actions, canDefaults, { selectedRows, reloadTable }) { - // console.log('Start clean actions: ', selectedRows.length, reloadTable) + // debug('Start clean actions: ', selectedRows.length, reloadTable) const cleanedActions = [] const cloneActions = _.cloneDeep(actions) cloneActions.forEach((action) => { diff --git a/src/components/TableFormatters/DateFormatter.vue b/src/components/TableFormatters/DateFormatter.vue index 88a2f4156..4f2da1d09 100644 --- a/src/components/TableFormatters/DateFormatter.vue +++ b/src/components/TableFormatters/DateFormatter.vue @@ -17,7 +17,7 @@ export default { } // const locale = this.$i18n.locale // const value = dt.toLocaleString(locale, { hourCycle: 'h23' }) - // console.log(this.$i18n.locale) + // debug(this.$i18n.locale) return { value: value } diff --git a/src/components/TreeTable/index.vue b/src/components/TreeTable/index.vue index 500be32de..1dbdb2d94 100644 --- a/src/components/TreeTable/index.vue +++ b/src/components/TreeTable/index.vue @@ -77,7 +77,7 @@ export default { } }, mounted() { - // console.log(this.treeSetting) + // debug(this.treeSetting) }, methods: { handleUrlChange(url) { diff --git a/src/guards.js b/src/guards.js index 82c6d8397..daee33ee4 100644 --- a/src/guards.js +++ b/src/guards.js @@ -18,7 +18,7 @@ router.beforeEach(async(to, from, next) => { next() } catch (e) { const msg = 'Start service error: ' + e - console.log(e) + // debug(e) } }) diff --git a/src/store/modules/permission.js b/src/store/modules/permission.js index 14f02be22..f587d70ca 100644 --- a/src/store/modules/permission.js +++ b/src/store/modules/permission.js @@ -126,7 +126,7 @@ function cleanRoute(tmp, parent) { } else { tmp.meta.fullPath = parentFullPath ? parentFullPath + '/' + tmp.path : parentFullPath } - // console.log('Full path: ', tmp.meta.fullPath) + // debug('Full path: ', tmp.meta.fullPath) } // 设置默认active menu if (tmp.meta.type === 'crud' && !tmp.meta.activeMenu) { diff --git a/src/store/modules/users.js b/src/store/modules/users.js index 9b936e66c..76af3cb8c 100644 --- a/src/store/modules/users.js +++ b/src/store/modules/users.js @@ -82,7 +82,7 @@ const actions = { commit('SET_PROFILE', response) resolve(response) }).catch(error => { - // console.log(error) + // debug(error) reject(error) }) }) diff --git a/src/utils/request.js b/src/utils/request.js index 16fac6142..aa3c8513e 100644 --- a/src/utils/request.js +++ b/src/utils/request.js @@ -36,7 +36,7 @@ function beforeRequestAddTimezone(config) { try { config.headers['X-TZ'] = Intl.DateTimeFormat().resolvedOptions().timeZone } catch (e) { - console.log('Current browser not support Intl tools') + // debug('Current browser not support Intl tools') } } @@ -51,7 +51,7 @@ service.interceptors.request.use( }, error => { // do something with request error - console.log(error) // for debug + // debug(error) // for debug return Promise.reject(error) } ) diff --git a/src/views/assets/Asset/TreeMenu.vue b/src/views/assets/Asset/TreeMenu.vue index 08ab70ed5..b76e94b74 100644 --- a/src/views/assets/Asset/TreeMenu.vue +++ b/src/views/assets/Asset/TreeMenu.vue @@ -172,7 +172,7 @@ export default { }) }, hideMenu() { - console.log('Tree: ', this.tree) + // debug('Tree: ', this.tree) this.tree.hideRMenu() }, getSelectedNodes() { diff --git a/src/views/login/index.vue b/src/views/login/index.vue index b74add58c..f4354083d 100644 --- a/src/views/login/index.vue +++ b/src/views/login/index.vue @@ -116,7 +116,7 @@ export default { this.loading = false }) } else { - console.log('error submit!!') + // debug('error submit!!') return false } }) diff --git a/src/views/settings/Message/index.vue b/src/views/settings/Message/index.vue index e4c84baea..b8523ce63 100644 --- a/src/views/settings/Message/index.vue +++ b/src/views/settings/Message/index.vue @@ -101,8 +101,8 @@ export default { ).then(newSub => { const msgType = this.idMessageTypeMapper[newSub.message_type] msgType.receivers = newSub.receivers - }).catch(err => { - console.log(err) + }).catch(() => { + // debug(err) }) }, getNameDisplay(header) { diff --git a/tests/unit/components/Breadcrumb.spec.js b/tests/unit/components/Breadcrumb.spec.js index 1d94c8fc7..a19277bf7 100644 --- a/tests/unit/components/Breadcrumb.spec.js +++ b/tests/unit/components/Breadcrumb.spec.js @@ -79,7 +79,7 @@ describe('Breadcrumb.vue', () => { // router.push('/menu/menu1/menu1-2/menu1-2-2') // const breadcrumbArray = wrapper.findAll('.el-breadcrumb__inner') // const second = breadcrumbArray.at(1) - // console.log(breadcrumbArray) + // // debug(breadcrumbArray) // const href = second.find('a').attributes().href // expect(href).toBe('#/menu/menu1') // })