From a1c4013a6940d370fbca88ceebe6c4709dae4d4f Mon Sep 17 00:00:00 2001
From: feng <1304903146@qq.com>
Date: Thu, 27 Jul 2023 19:12:20 +0800
Subject: [PATCH] =?UTF-8?q?perf:=20=E4=BC=98=E5=8C=96ldap=E4=BA=A4?=
 =?UTF-8?q?=E4=BA=92?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/i18n/langs/en.json                   |  1 +
 src/i18n/langs/ja.json                   |  1 +
 src/i18n/langs/zh.json                   |  1 +
 src/views/settings/Ldap/ImportDialog.vue | 94 +++++++++++++++++-------
 src/views/settings/Ldap/index.vue        |  2 +-
 5 files changed, 70 insertions(+), 29 deletions(-)

diff --git a/src/i18n/langs/en.json b/src/i18n/langs/en.json
index 0463120e4..fa8a295fb 100644
--- a/src/i18n/langs/en.json
+++ b/src/i18n/langs/en.json
@@ -1581,6 +1581,7 @@
     "authSAMLCertHelpText": "After upload cert and private key, View SP Metadata",
     "authSAML2AdvancedSettings": "Advanced Settings",
     "unselectedUser": "Unselected user",
+    "unselectedOrg": "Unselected org",
     "auto": "Auto",
     "basicSetting": "Basic setting",
     "communityEdition": "Community edition",
diff --git a/src/i18n/langs/ja.json b/src/i18n/langs/ja.json
index 751d4bc2e..8b641ab22 100644
--- a/src/i18n/langs/ja.json
+++ b/src/i18n/langs/ja.json
@@ -1586,6 +1586,7 @@
     "authCASAttrMap": "ユーザー属性マッピング",
     "SignaturesAndTemplates": "署名とテンプレート",
     "unselectedUser": "ユーザーを選択していない",
+    "unselectedOrg": "組織を選択していない",
     "auto": "自動",
     "basicSetting": "基本設定",
     "communityEdition": "コミュニティ版",
diff --git a/src/i18n/langs/zh.json b/src/i18n/langs/zh.json
index 70bc026d0..35d57dd6c 100644
--- a/src/i18n/langs/zh.json
+++ b/src/i18n/langs/zh.json
@@ -1580,6 +1580,7 @@
     "authCASAttrMap": "用户属性映射",
     "SignaturesAndTemplates": "Signatures and Templates",
     "unselectedUser": "没有选择用户",
+    "unselectedOrg": "没有选择组织",
     "auto": "自动",
     "basicSetting": "基本设置",
     "communityEdition": "社区版",
diff --git a/src/views/settings/Ldap/ImportDialog.vue b/src/views/settings/Ldap/ImportDialog.vue
index 0dffd1582..7e53a6580 100644
--- a/src/views/settings/Ldap/ImportDialog.vue
+++ b/src/views/settings/Ldap/ImportDialog.vue
@@ -13,20 +13,27 @@
         class="listTable"
         :table-config="tableConfig"
         :header-actions="headerActions"
-        @error="handlerListTableXHRError($event)"
       />
       <div slot="footer">
-        <span class="org-select">
+        <span v-show="showOrgSelect" class="org-select">
           <span class="label">{{ $tc('common.ImportOrg') }}：</span>
-          <Select2 ref="select2" v-model="select2.value" v-bind="select2" popper-class="select-org-dropdown" />
+          <Select2
+            ref="select2"
+            v-model="select2.value"
+            v-bind="select2"
+            popper-class="select-org-dropdown"
+          />
         </span>
-        <el-button type="primary" size="small" :loading="dialogLdapUserImportLoginStatus" @click="importUserClick">{{ $t('common.Import') }}</el-button>
+        <el-button type="primary" size="small" :loading="dialogLdapUserImportLoginStatus" @click="importUserClick">
+          {{ $t('common.Import') }}
+        </el-button>
         <el-button
           type="primary"
           size="small"
           :loading="dialogLdapUserImportAllLoginStatus"
           @click="importAllUserClick"
-        >{{ $t('common.ImportAll') }}</el-button>
+        >{{ $t('common.ImportAll') }}
+        </el-button>
         <el-button size="small" @click="hiddenDialog">{{ $t('common.Cancel') }}</el-button>
       </div>
     </Dialog>
@@ -35,6 +42,7 @@
 
 <script>
 import store from '@/store'
+import { DEFAULT_ORG_ID, SYSTEM_ORG_ID } from '@/utils/org'
 import ListTable from '@/components/ListTable'
 import Dialog from '@/components/Dialog'
 import Select2 from '@/components/FormFields/Select2'
@@ -101,31 +109,52 @@ export default {
         ajax: {
           url: '/api/v1/orgs/orgs/',
           transformOption: (item) => {
-            return { label: item.name, value: item.id }
+            if (item.id !== SYSTEM_ORG_ID) {
+              return { label: item.name, value: item.id }
+            }
           }
         },
-        value: store.getters.publicSettings.AUTH_LDAP_SYNC_ORG_IDS
+        value: this.orgIds()
       }
     }
   },
+  computed: {
+    showOrgSelect() {
+      return store.getters.hasValidLicense
+    }
+  },
   methods: {
+    orgIds() {
+      let orgIds = []
+      if (store.getters.hasValidLicense) {
+        const allOrgIds = store.getters.publicSettings.AUTH_LDAP_SYNC_ORG_IDS
+        orgIds = allOrgIds.filter(item => item.id !== SYSTEM_ORG_ID)
+      } else {
+        orgIds = [DEFAULT_ORG_ID]
+      }
+      return orgIds
+    },
     importUserClick() {
       this.dialogLdapUserImportLoginStatus = true
       const selectIds = []
       this.$refs.listTable.selectedRows.forEach((item, index) => {
         selectIds.push(item.id)
       })
+      const org_ids = this.select2.value || []
       const data = {
-        org_ids: this.select2.value,
+        org_ids: org_ids,
         username_list: selectIds
       }
+      console.log('store.getters.publicSettings.AUTH_LDAP_SYNC_ORG_IDS', store.getters.publicSettings.AUTH_LDAP_SYNC_ORG_IDS)
       if (selectIds.length === 0) {
         this.$message.error(this.$tc('setting.unselectedUser'))
         this.dialogLdapUserImportLoginStatus = false
+      } else if (org_ids.length === 0) {
+        this.$message.error(this.$tc('setting.unselectedOrg'))
+        this.dialogLdapUserImportLoginStatus = false
       } else {
         importLdapUser(data).then(res => {
           this.$message.success(res.msg)
-          // eslint-disable-next-line no-return-assign
         }).catch(error => {
           const errorMessage = getErrorResponseMsg(error) || this.$t('common.imExport.ImportFail')
           this.$message.error(errorMessage)
@@ -136,14 +165,21 @@ export default {
     },
     importAllUserClick() {
       this.dialogLdapUserImportAllLoginStatus = true
+      const org_ids = this.select2.value || []
       const data = {
-        org_ids: this.select2.value,
+        org_ids: org_ids,
         username_list: ['*']
       }
-      importLdapUser(data).then(res => {
-        this.$message.success(res.msg)
-        // eslint-disable-next-line no-return-assign
-      }).finally(() => this.dialogLdapUserImportAllLoginStatus = false)
+      if (org_ids.length === 0) {
+        this.$message.error(this.$tc('setting.unselectedOrg'))
+        this.dialogLdapUserImportLoginStatus = false
+      } else {
+        importLdapUser(data).then(res => {
+          this.$message.success(res.msg)
+        }).finally(() => {
+          this.dialogLdapUserImportAllLoginStatus = false
+        })
+      }
     },
     handlerListTableXHRError(errMsg) {
       if (this.dialogLdapUserImport) {
@@ -159,24 +195,26 @@ export default {
 
 <style>
 .el-select-dropdown.select-org-dropdown {
-  max-width: 300px!important;
+  max-width: 300px !important;
 }
 </style>
 
 <style scoped lang="scss">
-  .org-select {
-    float: left;
-    width: 300px;
-    display: inline-block;
-    text-align: left;
-    padding-left: 14px;
-    .label {
-      font-weight:bold;
-      width: 100px!important;
-    }
-    .select2 {
-      width: 180px!important;
-    }
+.org-select {
+  float: left;
+  width: 300px;
+  display: inline-block;
+  text-align: left;
+  padding-left: 14px;
+
+  .label {
+    font-weight: bold;
+    width: 100px !important;
   }
 
+  .select2 {
+    width: 180px !important;
+  }
+}
+
 </style>
diff --git a/src/views/settings/Ldap/index.vue b/src/views/settings/Ldap/index.vue
index 0aec15a59..53e8787a0 100644
--- a/src/views/settings/Ldap/index.vue
+++ b/src/views/settings/Ldap/index.vue
@@ -1,7 +1,7 @@
 <template>
   <IBox>
     <GenericCreateUpdateForm v-bind="$data" />
-    <ImportDialog :visible.sync="dialogLdapUserImport" />
+    <ImportDialog v-if="dialogLdapUserImport" :visible.sync="dialogLdapUserImport" />
     <TestLoginDialog :visible.sync="dialogTest" />
     <SyncSettingDialog :visible.sync="dialogSyncSetting" />
   </IBox>