From b8ba53cf5eef563ab6d166cb73000ade6fff5181 Mon Sep 17 00:00:00 2001
From: fit2bot <68588906+fit2bot@users.noreply.github.com>
Date: Thu, 15 Jul 2021 10:30:22 +0800
Subject: [PATCH] =?UTF-8?q?perf:=20=E6=B7=BB=E5=8A=A0=20=E7=B3=BB=E7=BB=9F?=
 =?UTF-8?q?=E7=94=A8=E6=88=B7=20=E5=88=B0=20=20=E8=B4=A6=E5=8F=B7=20(#911)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: ibuler <ibuler@qq.com>
---
 src/components/AccountListTable/index.vue      |  7 +++++--
 .../TableFormatters/ChoicesFormatter.vue       |  1 -
 src/views/acl/AssetAcl/AssetAclList.vue        | 11 +++++++++--
 src/views/assets/Asset/AssetDetail/Detail.vue  | 18 ------------------
 .../SystemUser/SystemUserDetail/index.vue      |  4 ++--
 5 files changed, 16 insertions(+), 25 deletions(-)

diff --git a/src/components/AccountListTable/index.vue b/src/components/AccountListTable/index.vue
index f66cdbce8..bb426535d 100644
--- a/src/components/AccountListTable/index.vue
+++ b/src/components/AccountListTable/index.vue
@@ -8,7 +8,7 @@
 
 <script>
 import ListTable from '@/components/ListTable/index'
-import { ActionsFormatter, DetailFormatter } from '@/components/TableFormatters'
+import { ActionsFormatter, DetailFormatter, DisplayFormatter } from '@/components/TableFormatters'
 import ShowSecretInfo from './ShowSecretInfo'
 import UpdateSecretInfo from './UpdateSecretInfo'
 import { connectivityMeta } from './const'
@@ -53,7 +53,7 @@ export default {
         url: this.url,
         columns: [
           'hostname', 'ip', 'username', 'version', 'connectivity',
-          'date_created', 'date_updated', 'actions'
+          'systemuser', 'date_created', 'date_updated', 'actions'
         ],
         columnsShow: {
           min: ['username', 'actions'],
@@ -80,6 +80,9 @@ export default {
           username: {
             showOverflowTooltip: true
           },
+          systemuser: {
+            formatter: DisplayFormatter
+          },
           version: {
             width: '70px'
           },
diff --git a/src/components/TableFormatters/ChoicesFormatter.vue b/src/components/TableFormatters/ChoicesFormatter.vue
index 792695395..634274010 100644
--- a/src/components/TableFormatters/ChoicesFormatter.vue
+++ b/src/components/TableFormatters/ChoicesFormatter.vue
@@ -41,7 +41,6 @@ export default {
   computed: {
     iconClass() {
       const key = this.formatterArgs.getIconKey({ row: this.row, cellValue: this.cellValue })
-      console.log('What key: ', key)
       return this.formatterArgs.iconChoices[key]
     },
     tips() {
diff --git a/src/views/acl/AssetAcl/AssetAclList.vue b/src/views/acl/AssetAcl/AssetAclList.vue
index 57118a531..410ff7b1a 100644
--- a/src/views/acl/AssetAcl/AssetAclList.vue
+++ b/src/views/acl/AssetAcl/AssetAclList.vue
@@ -13,10 +13,17 @@ export default {
     return {
       tableConfig: {
         url: '/api/v1/acls/login-asset-acls/',
-        columns: ['name', 'user_username_group', 'hostname_group', 'ip_group', 'name_group', 'protocol_group', 'systemuser_username_group', 'reviewers', 'priority', 'is_active', 'comment', 'actions'],
+        columns: [
+          'name', 'user_username_group', 'hostname_group', 'ip_group', 'name_group',
+          'protocol_group', 'systemuser_username_group', 'reviewers', 'priority',
+          'is_active', 'comment', 'actions'
+        ],
         columnsShow: {
           min: ['name', 'actions'],
-          default: ['name', 'user_username_group', 'hostname_group', 'ip_group', 'reviewers', 'priority', 'is_active', 'comment', 'actions']
+          default: [
+            'name', 'user_username_group', 'hostname_group', 'ip_group', 'reviewers',
+            'priority', 'is_active', 'comment', 'actions'
+          ]
         },
         columnsMeta: {
           user_username_group: {
diff --git a/src/views/assets/Asset/AssetDetail/Detail.vue b/src/views/assets/Asset/AssetDetail/Detail.vue
index 4c1d7ede6..6adb7dcc8 100644
--- a/src/views/assets/Asset/AssetDetail/Detail.vue
+++ b/src/views/assets/Asset/AssetDetail/Detail.vue
@@ -91,24 +91,6 @@ export default {
             }.bind(this)
           }
         }
-        // {
-        //   title: this.$t('assets.PushSystemUserNow'),
-        //   attrs: {
-        //     type: 'primary',
-        //     label: this.$t('assets.Push')
-        //   },
-        //   callbacks: {
-        //     click: function() {
-        //       this.$axios.post(
-        //         `api/v1/assets/system-users/${this.object.id}/tasks/`,
-        //         { action: 'push' }
-        //       ).then(res => {
-        //         window.open(`/ops/celery/task/${res.task}/log/`, '', 'width=900,height=600')
-        //       }
-        //       )
-        //     }.bind(this)
-        //   }
-        // }
       ],
       nodeRelationConfig: {
         icon: 'fa-info',
diff --git a/src/views/assets/SystemUser/SystemUserDetail/index.vue b/src/views/assets/SystemUser/SystemUserDetail/index.vue
index 17ef2e992..e10ceee13 100644
--- a/src/views/assets/SystemUser/SystemUserDetail/index.vue
+++ b/src/views/assets/SystemUser/SystemUserDetail/index.vue
@@ -48,8 +48,8 @@ export default {
               name: routeName,
               params: { id: id },
               query: {
-                protocol: vm.systemUser.protocol,
-                type: vm.systemUser.type
+                type: vm.systemUser.type,
+                protocol: vm.systemUser.protocol
               }
             })
           }