From 8fab3e56074153fd18e3ceb6f9de7ceb4d77eec1 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Fri, 17 Jun 2016 13:46:32 +0100 Subject: [PATCH] Avoid brace expansion which is a bashism. Building on Debian where /bin/sh is dash: make[1]: Leaving directory '/home/ijc/development/Docker/moby.git/alpine/packages/docker/docker.git' mkdir -p bin cp docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc} bin/ cp: cannot stat 'docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc}': No such file or directory Makefile:9: recipe for target 'bin' failed Pasting the construct into a file and running checkbashsisms: possible bashism in foo line 2 (brace expansion): cp docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc} bin/ Signed-off-by: Ian Campbell --- alpine/packages/docker/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/alpine/packages/docker/Makefile b/alpine/packages/docker/Makefile index da5ee025d..5e737fe1e 100644 --- a/alpine/packages/docker/Makefile +++ b/alpine/packages/docker/Makefile @@ -9,8 +9,11 @@ bin: docker.git (cd docker.git && git fetch origin --tags && git checkout moby-$(DOCKER_VERSION)) DOCKER_EXPERIMENTAL=$(EXPERIMENTAL) BIND_DIR=$(shell pwd) make -C docker.git binary mkdir -p bin - cp docker.git/bundles/latest/binary-daemon/{dockerd,docker-runc} bin/ - cp docker.git/bundles/latest/binary-daemon/{docker-containerd,docker-containerd-shim,docker-containerd-ctr} bin/ + cp docker.git/bundles/latest/binary-daemon/dockerd bin/ + cp docker.git/bundles/latest/binary-daemon/docker-runc bin/ + cp docker.git/bundles/latest/binary-daemon/docker-containerd bin/ + cp docker.git/bundles/latest/binary-daemon/docker-containerd-shim bin/ + cp docker.git/bundles/latest/binary-daemon/docker-containerd-ctr bin/ cp docker.git/bundles/latest/binary-daemon/docker-proxy bin/ cp docker.git/bundles/latest/binary-client/docker bin/