From fb22969380ad51ee40cbd0d2dce0a78c835dc2d7 Mon Sep 17 00:00:00 2001 From: Tycho Andersen Date: Mon, 6 Mar 2017 13:24:36 -0800 Subject: [PATCH] fix some shellcheck issues In d4m.sh line 14: (cd $DB && \ ^-- SC2086: Double quote to prevent globbing and word splitting. In d4m.sh line 21: (cd $DB; git reset --hard) ^-- SC2086: Double quote to prevent globbing and word splitting. In d4m.sh line 22: if [ -f ${DB}/${DB_BRIDGE} ]; then ^-- SC2086: Double quote to prevent globbing and word splitting. In d4m.sh line 23: content=$(cat ${DB}/${DB_BRIDGE}) ^-- SC2086: Double quote to prevent globbing and word splitting. In d4m.sh line 24: [ ${content} != "1" ] && enable_bridge ^-- SC2086: Double quote to prevent globbing and word splitting. In d4m.sh line 34: dd if=/dev/zero of=$DISK bs=1048576 count=256 ^-- SC2086: Double quote to prevent globbing and word splitting. Signed-off-by: Tycho Andersen --- scripts/d4m.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/d4m.sh b/scripts/d4m.sh index b7cb62488..7270df3de 100755 --- a/scripts/d4m.sh +++ b/scripts/d4m.sh @@ -11,17 +11,17 @@ DB_BRIDGE=com.docker.driver.amd64-linux/slirp/bridge-connections # Check if VPNKit L2 bridge mode is enabled enable_bridge() { - (cd $DB && \ + (cd "${DB}" && \ echo -n "1" > ${DB_BRIDGE} && \ git add ${DB_BRIDGE} && \ git commit -m "enable bridge" ) } -(cd $DB; git reset --hard) -if [ -f ${DB}/${DB_BRIDGE} ]; then - content=$(cat ${DB}/${DB_BRIDGE}) - [ ${content} != "1" ] && enable_bridge +(cd "${DB}"; git reset --hard) +if [ -f "${DB}/${DB_BRIDGE}" ]; then + content=$(cat "${DB}/${DB_BRIDGE}") + [ "${content}" != "1" ] && enable_bridge else enable_bridge fi @@ -31,7 +31,7 @@ KERNEL="kernel/x86_64/vmlinuz64" CMDLINE="earlyprintk=serial console=ttyS0" DISK=$(mktemp disk.img.XXXX) -dd if=/dev/zero of=$DISK bs=1048576 count=256 +dd if=/dev/zero of="$DISK" bs=1048576 count=256 MEM="-m 1G" SMP="-c 1"