github/linuxkit
1
0
Fork 0
mirror of https://github.com/linuxkit/linuxkit.git synced 2025-07-29 13:38:00 +00:00
Code Issues Projects Releases Wiki Activity

tap-vsockd: use stderr rather than syslog if service guid is wrong

Browse Source 
Our convention is to print command-line parse failures to the terminal
to allow easier interactive debugging, rather than sending them to
the syslog.

Signed-off-by: David Scott <dave.scott@docker.com>
This commit is contained in:
David Scott 2016-05-21 14:10:16 +01:00
parent 1805c803a9
commit 1e96379e3f
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
alpine/packages/tap-vsockd/tap-vsockd.c
View File

@ -387,19 +387,19 @@ int main(int argc, char **argv)
fprintf(stderr, "For daemon mode, please supply a --pidfile argument.\n"); fprintf(stderr, "For daemon mode, please supply a --pidfile argument.\n");
exit(1); exit(1);
} }
res = parseguid(serviceid, &sid);
if (res) {
fprintf(stderr, "Failed to parse serviceid as GUID: %s\n", serviceid);
usage(argv[0]);
exit(1);
}
int log_flags = LOG_CONS | LOG_NDELAY; int log_flags = LOG_CONS | LOG_NDELAY;
if (!daemon_flag) { if (!daemon_flag) {
log_flags |= LOG_PERROR; log_flags |= LOG_PERROR;
} }
openlog(argv[0], log_flags, LOG_DAEMON); openlog(argv[0], log_flags, LOG_DAEMON);
res = parseguid(serviceid, &sid);
if (res) {
syslog(LOG_CRIT, "Failed to parse serviceid as GUID: %s", serviceid);
usage(argv[0]);
exit(1);
}
int sock = -1; int sock = -1;
if (listen_flag) { if (listen_flag) {
syslog(LOG_INFO, "starting in listening mode with serviceid=%s and tap=%s", serviceid, tap); syslog(LOG_INFO, "starting in listening mode with serviceid=%s and tap=%s", serviceid, tap);