From 58706fd84ee23b07de012d5844cbb63ebb4fd2ef Mon Sep 17 00:00:00 2001 From: David Sheets Date: Wed, 14 Dec 2016 16:20:29 +0000 Subject: [PATCH] transfused: use memcmp instead of a loop for checking init message Signed-off-by: David Sheets --- alpine/packages/transfused/transfused.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/alpine/packages/transfused/transfused.c b/alpine/packages/transfused/transfused.c index d94fd54ab..be219e131 100644 --- a/alpine/packages/transfused/transfused.c +++ b/alpine/packages/transfused/transfused.c @@ -938,10 +938,9 @@ void *init_thread(void *params_ptr) buf = must_malloc("incoming control message buffer", CTL_BUFSZ); /* TODO: handle other messages */ - read_exactly("init thread", params->ctl_sock, buf, 6); - for (int i = 0; i < sizeof(init_msg); i++) - if (((char *)buf)[i] != init_msg[i]) - die(1, params, NULL, "init thread: unexpected message"); + read_exactly("init thread", params->ctl_sock, buf, sizeof(init_msg)); + if (memcmp(buf, init_msg, sizeof(init_msg))) + die(1, params, NULL, "init thread: unexpected message"); /* we've gotten Continue so write the pidfile */ if (params->pidfile != NULL)