add go vet and go lint

Signed-off-by: Avi Deitcher <avi@deitcher.net>

.github/workflows/ci.yml

@@ -35,35 +35,29 @@ jobs:
     runs-on: ${{ matrix.target.runner }}
     steps:
 
-    - name: Set up Go 1.16
+    - name: Set up Go 1.19
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.16.7
+        go-version: 1.19.2
       id: go
 
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Set path
       run: echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
       env:
          GOPATH: ${{runner.workspace}}
 
-    - name: Get pre-requisites
+    - name: golangci-lint CLI
+      uses: golangci/golangci-lint-action@v3
+      with:
+        version: v1.50.0
+        working-directory: src/cmd/linuxkit
+        args: --verbose --timeout=10m
+    - name: go vet CLI
       run: |
-            go get -u golang.org/x/lint/golint
+        cd src/cmd/linuxkit && go vet ./...
-            go get -u github.com/gordonklaus/ineffassign
-      env:
-        GOPATH: ${{runner.workspace}}
-
-    # - name: Lint
-    #   run: |
-    #     make local-check
-    #   env:
-    #     GOPATH: ${{runner.workspace}}
-
     - name: Build
       run: |
         make GOARCH=${{matrix.target.arch}} GOOS=${{matrix.target.os}} LOCAL_TARGET=$(pwd)/bin/linuxkit-${{matrix.target.suffix}} local-build
@@ -99,9 +93,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Set up binfmt
       # Only register arm64 as we are on amd64 already. s390x is not reliable
@@ -138,9 +130,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Install Pre-Requisites
       run: |
@@ -194,9 +184,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Install Pre-Requisites
       run: |
@@ -242,9 +230,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Install Pre-Requisites
       run: |
@@ -290,9 +276,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Install Pre-Requisites
       run: |
@@ -338,9 +322,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Install Pre-Requisites
       run: |

.github/workflows/publish.yaml

@@ -14,9 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
     - name: Ensure bin/ directory
       run: mkdir -p bin
     - name: Download linuxkit

.github/workflows/release.yml

@@ -11,16 +11,14 @@ jobs:
     runs-on: macos-latest
     steps:
 
-    - name: Set up Go 1.16
+    - name: Set up Go 1.19
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.16.7
+        go-version: 1.19.2
       id: go
 
     - name: Check out code
-      uses: actions/checkout@v1
+      uses: actions/checkout@v3
-      with:
-        path: ./src/github.com/linuxkit/linuxkit
 
     - name: Set path
       run: echo "$(go env GOPATH)/bin" >> $GITHUB_PATH