From 66f9cc134f735efe5822053e368ae944c1bf1e51 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Wed, 28 Jun 2017 12:04:10 +0100 Subject: [PATCH] pkg: Consolidate $(TAG) to be the full tag Saves lots of repetitions of `$(ORG)/$(IMAGE):$(HASH)$(DIRTY)` throughout the file. Signed-off-by: Ian Campbell --- pkg/package.mk | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/package.mk b/pkg/package.mk index 025c68600..e169a1353 100644 --- a/pkg/package.mk +++ b/pkg/package.mk @@ -6,7 +6,7 @@ HASH?=$(shell git ls-tree HEAD -- ../$(notdir $(CURDIR)) | awk '{print $$3}') BASE_DEPS=Dockerfile Makefile DIRTY=$(shell git diff-index --quiet HEAD -- ../$(notdir $(CURDIR)) || echo "-dirty") -TAG=$(HASH)$(DIRTY) +TAG=$(ORG)/$(IMAGE):$(HASH)$(DIRTY) # Get a release tag, if present RELEASE=$(shell git tag -l --points-at HEAD) @@ -18,19 +18,19 @@ NET_OPT=--network=none endif show-tag: - @echo $(ORG)/$(IMAGE):$(TAG) + @echo $(TAG) tag: $(BASE_DEPS) $(DEPS) - DOCKER_CONTENT_TRUST=1 docker pull $(ORG)/$(IMAGE):$(TAG) || \ - docker build $(NET_OPT) -t $(ORG)/$(IMAGE):$(TAG) . + DOCKER_CONTENT_TRUST=1 docker pull $(TAG) || \ + docker build $(NET_OPT) -t $(TAG) . push: tag ifneq ($(DIRTY),) $(error Your repository is not clean. Will not push package image.) endif - DOCKER_CONTENT_TRUST=1 docker pull $(ORG)/$(IMAGE):$(TAG) || \ - DOCKER_CONTENT_TRUST=1 docker push $(ORG)/$(IMAGE):$(TAG) + DOCKER_CONTENT_TRUST=1 docker pull $(TAG) || \ + DOCKER_CONTENT_TRUST=1 docker push $(TAG) ifneq ($(RELEASE),) - docker tag $(ORG)/$(IMAGE):$(TAG) $(ORG)/$(IMAGE):$(RELEASE) + docker tag $(TAG) $(ORG)/$(IMAGE):$(RELEASE) DOCKER_CONTENT_TRUST=1 docker push $(ORG)/$(IMAGE):$(RELEASE) endif