github/linuxkit
1
0
Fork 0
mirror of https://github.com/linuxkit/linuxkit.git synced 2025-07-27 20:48:11 +00:00
Code Issues Projects Releases Wiki Activity

transfused: replace brittle event pid writing with write_exactly

Browse Source 
Signed-off-by: David Sheets <dsheets@docker.com>
This commit is contained in:
David Sheets 2016-12-14 14:40:33 +00:00
parent 78328cf026
commit 6cf50dd803
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
alpine/packages/transfused/transfused.c
View File

@ -744,23 +744,14 @@ void write_pid(connection_t *connection)
{ {
pid_t pid = gettid(); pid_t pid = gettid();
char *pid_s; char *pid_s;
int pid_s_len, write_count; int pid_s_len;
if (asprintf(&pid_s, "%lld", (long long)pid) == -1) if (asprintf(&pid_s, "%lld", (long long)pid) == -1)
die(1, connection->params, "Couldn't allocate pid string", ""); die(1, connection->params, "Couldn't allocate pid string", "");
pid_s_len = strlen(pid_s); pid_s_len = strlen(pid_s);
/* TODO: check for socket write conditions e.g.EAGAIN */ write_exactly("pid", connection->sock, pid_s, pid_s_len);
write_count = write(connection->sock, pid_s, pid_s_len);
if (write_count < 0)
die(1, connection->params, "Error writing pid", "");
/* TODO: handle short writes */
if (write_count != pid_s_len)
die(1, connection->params, NULL,
"Error writing pid %s to socket: only wrote %d bytes",
pid_s, write_count);
free(pid_s); free(pid_s);
} }