github/linuxkit
1
0
Fork 0
mirror of https://github.com/linuxkit/linuxkit.git synced 2025-07-19 17:26:28 +00:00
Code Issues Projects Releases Wiki Activity

Prefer nil empty slices

Browse Source 
Signed-off-by: David Gageot <david.gageot@docker.com>
This commit is contained in:
David Gageot 2022-10-07 20:40:04 +02:00
parent ebb5ded10b
commit 810c3e788f
No known key found for this signature in database
GPG Key ID: 93C3F22BE5D3A40B
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/init/cmd/rc.init/main.go
View File

@ -80,7 +80,7 @@ func mkdir(path string, perm os.FileMode) {
// list of all enabled cgroups // list of all enabled cgroups
func cgroupList() []string { func cgroupList() []string {
list := []string{} var list []string
f, err := os.Open("/proc/cgroups") f, err := os.Open("/proc/cgroups")
if err != nil { if err != nil {
log.Printf("cannot open /proc/cgroups: %v", err) log.Printf("cannot open /proc/cgroups: %v", err)
@ -125,7 +125,7 @@ func read(path string) string {
// read a directory // read a directory
func readdir(path string) []string { func readdir(path string) []string {
names := []string{} var names []string
files, err := os.ReadDir(path) files, err := os.ReadDir(path)
if err != nil { if err != nil {
log.Printf("cannot read directory %s: %v", path, err) log.Printf("cannot read directory %s: %v", path, err)

2
pkg/init/cmd/service/system_init.go
View File

@ -85,7 +85,7 @@ func systemInitCmd(ctx context.Context, args []string) {
_ = os.Remove(*sock) _ = os.Remove(*sock)
// look for containerd options // look for containerd options
ctrdArgs := []string{} var ctrdArgs []string
var ( var (
stderr io.Writer = os.Stderr stderr io.Writer = os.Stderr
stdout io.Writer = os.Stdout stdout io.Writer = os.Stdout

4
pkg/metadata/provider_cdrom.go
View File

@ -48,7 +48,7 @@ func ListCDROMs() []Provider {
cdroms = append(cidevs, cdroms...) cdroms = append(cidevs, cdroms...)
cdroms = uniqueString(cdroms) cdroms = uniqueString(cdroms)
log.Debugf("unique devices to be checked: %v", cdroms) log.Debugf("unique devices to be checked: %v", cdroms)
providers := []Provider{} var providers []Provider
for _, device := range cdroms { for _, device := range cdroms {
providers = append(providers, NewCDROM(device)) providers = append(providers, NewCDROM(device))
} }
@ -65,7 +65,7 @@ func FindCIs() []string {
// Glob can only error on invalid pattern // Glob can only error on invalid pattern
panic(fmt.Sprintf("Invalid glob pattern: %s", blockDevs)) panic(fmt.Sprintf("Invalid glob pattern: %s", blockDevs))
} }
foundDevices := []string{} var foundDevices []string
for _, device := range devs { for _, device := range devs {
// get the base device name // get the base device name
dev := filepath.Base(device) dev := filepath.Base(device)

2
pkg/mount/mountie.go
View File

@ -197,7 +197,7 @@ func makeDevLinks() error {
// return a list of all available drives // return a list of all available drives
func findDrives() []string { func findDrives() []string {
driveKeys := []string{} var driveKeys []string
ignoreExp := regexp.MustCompile(`^loop.*$|^nbd.*$|^[a-z]+[0-9]+$`) ignoreExp := regexp.MustCompile(`^loop.*$|^nbd.*$|^[a-z]+[0-9]+$`)
devs, _ := ioutil.ReadDir("/dev") devs, _ := ioutil.ReadDir("/dev")
for _, d := range devs { for _, d := range devs {