system → onboot daemon → services

As suggested by @shykes these are clearer

- onboot for things that are run at boot time to completion
- services for persistent services

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
This commit is contained in:
Justin Cormack 2017-04-08 16:56:47 +01:00
parent 68d8788e3b
commit 8176403426
2 changed files with 11 additions and 11 deletions

View File

@ -137,8 +137,8 @@ func buildInternal(name string, pull bool, conf string) {
initrdAppend(iw, buffer) initrdAppend(iw, buffer)
} }
log.Infof("Add system containers:") log.Infof("Add onboot containers:")
for i, image := range m.System { for i, image := range m.Onboot {
if pull || enforceContentTrust(image.Image, &m.Trust) { if pull || enforceContentTrust(image.Image, &m.Trust) {
log.Infof(" Pull: %s", image.Image) log.Infof(" Pull: %s", image.Image)
err := dockerPull(image.Image, enforceContentTrust(image.Image, &m.Trust)) err := dockerPull(image.Image, enforceContentTrust(image.Image, &m.Trust))
@ -152,7 +152,7 @@ func buildInternal(name string, pull bool, conf string) {
log.Fatalf("Failed to create config.json for %s: %v", image.Image, err) log.Fatalf("Failed to create config.json for %s: %v", image.Image, err)
} }
so := fmt.Sprintf("%03d", i) so := fmt.Sprintf("%03d", i)
path := "containers/system/" + so + "-" + image.Name path := "containers/onboot/" + so + "-" + image.Name
out, err := ImageBundle(path, image.Image, config) out, err := ImageBundle(path, image.Image, config)
if err != nil { if err != nil {
log.Fatalf("Failed to extract root filesystem for %s: %v", image.Image, err) log.Fatalf("Failed to extract root filesystem for %s: %v", image.Image, err)
@ -161,8 +161,8 @@ func buildInternal(name string, pull bool, conf string) {
initrdAppend(iw, buffer) initrdAppend(iw, buffer)
} }
log.Infof("Add daemon containers:") log.Infof("Add service containers:")
for _, image := range m.Daemon { for _, image := range m.Services {
if pull || enforceContentTrust(image.Image, &m.Trust) { if pull || enforceContentTrust(image.Image, &m.Trust) {
log.Infof(" Pull: %s", image.Image) log.Infof(" Pull: %s", image.Image)
err := dockerPull(image.Image, enforceContentTrust(image.Image, &m.Trust)) err := dockerPull(image.Image, enforceContentTrust(image.Image, &m.Trust))
@ -175,7 +175,7 @@ func buildInternal(name string, pull bool, conf string) {
if err != nil { if err != nil {
log.Fatalf("Failed to create config.json for %s: %v", image.Image, err) log.Fatalf("Failed to create config.json for %s: %v", image.Image, err)
} }
path := "containers/daemon/" + image.Name path := "containers/services/" + image.Name
out, err := ImageBundle(path, image.Image, config) out, err := ImageBundle(path, image.Image, config)
if err != nil { if err != nil {
log.Fatalf("Failed to extract root filesystem for %s: %v", image.Image, err) log.Fatalf("Failed to extract root filesystem for %s: %v", image.Image, err)

View File

@ -24,11 +24,11 @@ type Moby struct {
Image string Image string
Cmdline string Cmdline string
} }
Init []string Init []string
System []MobyImage Onboot []MobyImage
Daemon []MobyImage Services []MobyImage
Trust TrustConfig Trust TrustConfig
Files []struct { Files []struct {
Path string Path string
Directory bool Directory bool
Contents string Contents string