From 1e97929ec5e6b3e3bd3f6b06a9a857fbc1ee94cf Mon Sep 17 00:00:00 2001 From: Justin Cormack Date: Wed, 27 Dec 2017 18:17:45 +0000 Subject: [PATCH 1/2] Fix sriov flag on AWS This needs to be set to nil if empty. Signed-off-by: Justin Cormack --- src/cmd/linuxkit/push_aws.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cmd/linuxkit/push_aws.go b/src/cmd/linuxkit/push_aws.go index 18aa93689..3b5fe06ef 100644 --- a/src/cmd/linuxkit/push_aws.go +++ b/src/cmd/linuxkit/push_aws.go @@ -48,6 +48,9 @@ func pushAWS(args []string) { timeout := getIntValue(timeoutVar, *timeoutFlag, 600) bucket := getStringValue(bucketVar, *bucketFlag, "") name := getStringValue(nameVar, *nameFlag, "") + if *sriovNetFlag == "" { + sriovNetFlag = nil + } sess := session.Must(session.NewSession()) storage := s3.New(sess) From d04e9ba2a2af32173e69b169abc7d303f7a2efaa Mon Sep 17 00:00:00 2001 From: Justin Cormack Date: Wed, 27 Dec 2017 19:12:46 +0000 Subject: [PATCH 2/2] Improve docs for vmimport to mention role. Signed-off-by: Justin Cormack --- docs/platform-aws.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/platform-aws.md b/docs/platform-aws.md index 0377f8db4..e4b3d992d 100644 --- a/docs/platform-aws.md +++ b/docs/platform-aws.md @@ -27,6 +27,9 @@ $ linuxkit build -format aws examples/aws.yml ## Push image +Before you do this you need to create a `vmimport` service role as explained in +[the VM import documentation](http://docs.aws.amazon.com/vm-import/latest/userguide/vmimport-image-import.html). + Do `linuxkit push aws -bucket bucketname aws.raw` to upload it to the specified bucket, and create a bootable image from the stored image.