From b93922a1c54f761aa3a7de1c7fef555ef8cf2138 Mon Sep 17 00:00:00 2001 From: Riyaz Faizullabhoy Date: Fri, 28 Apr 2017 11:03:48 -0700 Subject: [PATCH] Add standard lint tools to Makefile Signed-off-by: Riyaz Faizullabhoy --- Makefile | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 77a6ddbfc..bd2288235 100644 --- a/Makefile +++ b/Makefile @@ -6,9 +6,18 @@ default: moby DEPS=$(wildcard cmd/moby/*.go) Makefile PREFIX?=/usr/local -moby: $(DEPS) +moby: $(DEPS) lint go build --ldflags "-X main.GitCommit=$(GIT_COMMIT) -X main.Version=$(VERSION)" -o $@ github.com/moby/tool/cmd/moby +lint: + @echo "+ $@: golint, gofmt, go vet" + # golint + @test -z "$(shell find . -type f -name "*.go" -not -path "./vendor/*" -not -name "*.pb.*" -exec golint {} \; | tee /dev/stderr)" + # gofmt + @test -z "$$(gofmt -s -l .| grep -v .pb. | grep -v vendor/ | tee /dev/stderr)" + # govet + @test -z "$$(go tool vet -printf=false . 2>&1 | grep -v vendor/ | tee /dev/stderr)" + PHONY: install install: moby cp -a $^ $(PREFIX)/bin/