mirror of
https://github.com/linuxkit/linuxkit.git
synced 2025-07-31 14:41:10 +00:00
55 lines
1.7 KiB
Diff
55 lines
1.7 KiB
Diff
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
Date: Tue, 9 Mar 2021 09:42:16 +0100
|
|
Subject: [PATCH 13/20] firewire: ohci: Use tasklet_disable_in_atomic() where
|
|
required
|
|
|
|
tasklet_disable() is invoked in several places. Some of them are in atomic
|
|
context which prevents a conversion of tasklet_disable() to a sleepable
|
|
function.
|
|
|
|
The atomic callchains are:
|
|
|
|
ar_context_tasklet()
|
|
ohci_cancel_packet()
|
|
tasklet_disable()
|
|
|
|
...
|
|
ohci_flush_iso_completions()
|
|
tasklet_disable()
|
|
|
|
The invocation of tasklet_disable() from at_context_flush() is always in
|
|
preemptible context.
|
|
|
|
Use tasklet_disable_in_atomic() for the two invocations in
|
|
ohci_cancel_packet() and ohci_flush_iso_completions().
|
|
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
|
|
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
|
|
Cc: linux1394-devel@lists.sourceforge.net
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
---
|
|
drivers/firewire/ohci.c | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
--- a/drivers/firewire/ohci.c
|
|
+++ b/drivers/firewire/ohci.c
|
|
@@ -2545,7 +2545,7 @@ static int ohci_cancel_packet(struct fw_
|
|
struct driver_data *driver_data = packet->driver_data;
|
|
int ret = -ENOENT;
|
|
|
|
- tasklet_disable(&ctx->tasklet);
|
|
+ tasklet_disable_in_atomic(&ctx->tasklet);
|
|
|
|
if (packet->ack != 0)
|
|
goto out;
|
|
@@ -3465,7 +3465,7 @@ static int ohci_flush_iso_completions(st
|
|
struct iso_context *ctx = container_of(base, struct iso_context, base);
|
|
int ret = 0;
|
|
|
|
- tasklet_disable(&ctx->context.tasklet);
|
|
+ tasklet_disable_in_atomic(&ctx->context.tasklet);
|
|
|
|
if (!test_and_set_bit_lock(0, &ctx->flushing_completions)) {
|
|
context_tasklet((unsigned long)&ctx->context);
|