mirror of
https://github.com/linuxkit/linuxkit.git
synced 2025-11-02 15:17:21 +00:00
8d0182e17c
4.10.x has been EOLed. Remove it from the build and tests. Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
63 lines
2.0 KiB
Diff
63 lines
2.0 KiB
Diff
From 2859826def85dd0df51267edd490e8666fc41757 Mon Sep 17 00:00:00 2001
|
|
From: Dexuan Cui <decui@microsoft.com>
|
|
Date: Fri, 5 May 2017 16:57:20 -0600
|
|
Subject: [PATCH 4/9] vmbus: remove "goto error_clean_msglist" in vmbus_open()
|
|
|
|
This is just a cleanup patch to simplify the code a little.
|
|
No semantic change.
|
|
|
|
Signed-off-by: Dexuan Cui <decui@microsoft.com>
|
|
Cc: K. Y. Srinivasan <kys@microsoft.com>
|
|
Cc: Haiyang Zhang <haiyangz@microsoft.com>
|
|
Cc: Stephen Hemminger <sthemmin@microsoft.com>
|
|
Origin: https://github.com/dcui/linux/commits/decui/hv_sock/v4.11/20170511
|
|
(cherry picked from commit 4713066c11b2396eafd2873cbed7bdd72d1571eb)
|
|
---
|
|
drivers/hv/channel.c | 18 +++++++-----------
|
|
1 file changed, 7 insertions(+), 11 deletions(-)
|
|
|
|
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
|
|
index 7cd2bd9fd1f1..db5e6f8730d2 100644
|
|
--- a/drivers/hv/channel.c
|
|
+++ b/drivers/hv/channel.c
|
|
@@ -180,17 +180,18 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
|
|
ret = vmbus_post_msg(open_msg,
|
|
sizeof(struct vmbus_channel_open_channel), true);
|
|
|
|
- if (ret != 0) {
|
|
- err = ret;
|
|
- goto error_clean_msglist;
|
|
- }
|
|
-
|
|
- wait_for_completion(&open_info->waitevent);
|
|
+ if (ret == 0)
|
|
+ wait_for_completion(&open_info->waitevent);
|
|
|
|
spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
|
|
list_del(&open_info->msglistentry);
|
|
spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
|
|
|
|
+ if (ret != 0) {
|
|
+ err = ret;
|
|
+ goto error_free_gpadl;
|
|
+ }
|
|
+
|
|
if (newchannel->rescind) {
|
|
err = -ENODEV;
|
|
goto error_free_gpadl;
|
|
@@ -205,11 +206,6 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
|
|
kfree(open_info);
|
|
return 0;
|
|
|
|
-error_clean_msglist:
|
|
- spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags);
|
|
- list_del(&open_info->msglistentry);
|
|
- spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
|
|
-
|
|
error_free_gpadl:
|
|
vmbus_teardown_gpadl(newchannel, newchannel->ringbuffer_gpadlhandle);
|
|
kfree(open_info);
|
|
--
|
|
2.13.0
|
|
|