github/ping
1
0
Fork 0
mirror of https://github.com/go-ping/ping.git synced 2025-09-19 17:26:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix CPU use (#40)

Browse Source 
* Move default case out of select block.
* Add defers to close resources.
* `go fmt` cleanup.
This commit is contained in:
Ben Kochie
2018-11-06 17:04:36 +01:00
committed by Cameron Sparr
parent 9db3df4bca
commit 3a0b5a7d8e
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ping.go
View File

@@ -286,6 +286,7 @@ func (p *Pinger) run() {
var wg sync.WaitGroup var wg sync.WaitGroup
recv := make(chan *packet, 5) recv := make(chan *packet, 5)
defer close(recv)
wg.Add(1) wg.Add(1)
go p.recvICMP(conn, recv, &wg) go p.recvICMP(conn, recv, &wg)
@@ -295,7 +296,9 @@ func (p *Pinger) run() {
} }
timeout := time.NewTicker(p.Timeout) timeout := time.NewTicker(p.Timeout)
defer timeout.Stop()
interval := time.NewTicker(p.Interval) interval := time.NewTicker(p.Interval)
defer interval.Stop()
for { for {
select { select {
@@ -316,12 +319,11 @@ func (p *Pinger) run() {
if err != nil { if err != nil {
fmt.Println("FATAL: ", err.Error()) fmt.Println("FATAL: ", err.Error())
} }
default: }
if p.Count > 0 && p.PacketsRecv >= p.Count { if p.Count > 0 && p.PacketsRecv >= p.Count {
close(p.done) close(p.done)
wg.Wait() wg.Wait()
return return
}
} }
} }
} }