From 8ef5fddf90d05acbe2c30649fe58975a0d8beb1c Mon Sep 17 00:00:00 2001
From: Florian Loch <florian.loch@exaring.de>
Date: Mon, 28 Feb 2022 13:33:43 +0100
Subject: [PATCH] refactor: simplify handling of done channel

---
 ping.go | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/ping.go b/ping.go
index 4ef7ef0..5948e4c 100644
--- a/ping.go
+++ b/ping.go
@@ -96,7 +96,7 @@ func New(addr string) *Pinger {
 		Size:              timeSliceLength + trackerLength,
 		Timeout:           time.Duration(math.MaxInt64),
 		addr:              addr,
-		done:              make(chan interface{}),
+		done:              make(chan struct{}),
 		id:                r.Intn(math.MaxUint16),
 		currentUUID:       uuid.New(),
 		ipaddr:            nil,
@@ -190,7 +190,7 @@ type Pinger struct {
 	Source string
 
 	// Channel and mutex used to communicate when the Pinger should stop between goroutines.
-	done chan interface{}
+	done chan struct{}
 	lock sync.Mutex
 
 	ipaddr *net.IPAddr
@@ -549,13 +549,10 @@ func (p *Pinger) Stop() {
 	p.lock.Lock()
 	defer p.lock.Unlock()
 
-	open := true
 	select {
-	case _, open = <-p.done:
+	case <-p.done:
+		return
 	default:
-	}
-
-	if open {
 		close(p.done)
 	}
 }