From 89a8e2795e19b1b3931ff9b92ef7cf021d264c80 Mon Sep 17 00:00:00 2001
From: Wesley Stewart <wstewart3@gmail.com>
Date: Wed, 13 Mar 2024 12:41:16 +0000
Subject: [PATCH] Updated chat_service to include settings in the actual class,
 instead of loading the settings function ()

---
 private_gpt/server/chat/chat_service.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/private_gpt/server/chat/chat_service.py b/private_gpt/server/chat/chat_service.py
index 6ae771d4..782c17e9 100644
--- a/private_gpt/server/chat/chat_service.py
+++ b/private_gpt/server/chat/chat_service.py
@@ -23,7 +23,7 @@ from private_gpt.components.vector_store.vector_store_component import (
 )
 from private_gpt.open_ai.extensions.context_filter import ContextFilter
 from private_gpt.server.chunks.chunks_service import Chunk
-from private_gpt.settings.settings import settings
+from private_gpt.settings.settings import Settings
 
 
 class Completion(BaseModel):
@@ -72,14 +72,18 @@ class ChatEngineInput:
 
 @singleton
 class ChatService:
+    settings: Settings
+
     @inject
     def __init__(
         self,
+        settings: Settings,
         llm_component: LLMComponent,
         vector_store_component: VectorStoreComponent,
         embedding_component: EmbeddingComponent,
         node_store_component: NodeStoreComponent,
     ) -> None:
+        self.settings = settings
         self.llm_component = llm_component
         self.embedding_component = embedding_component
         self.vector_store_component = vector_store_component
@@ -102,6 +106,7 @@ class ChatService:
         use_context: bool = False,
         context_filter: ContextFilter | None = None,
     ) -> BaseChatEngine:
+        settings = self.settings
         if use_context:
             vector_index_retriever = self.vector_store_component.get_retriever(
                 index=self.index, context_filter=context_filter
@@ -113,7 +118,7 @@ class ChatService:
                 node_postprocessors=[
                     MetadataReplacementPostProcessor(target_metadata_key="window"),
                     SimilarityPostprocessor(
-                        similarity_cutoff=settings().llm.similarity_value
+                        similarity_cutoff=settings.llm.similarity_value
                     ),
                 ],
             )