diff --git a/cmd/skopeo/signing_test.go b/cmd/skopeo/signing_test.go index b905facc..7cc94ea5 100644 --- a/cmd/skopeo/signing_test.go +++ b/cmd/skopeo/signing_test.go @@ -29,7 +29,8 @@ func assertTestFailed(t *testing.T, stdout string, err error, substring string) } func TestStandaloneSign(t *testing.T) { - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + t.Setenv("GNUPGHOME", "fixtures") + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { @@ -38,7 +39,6 @@ func TestStandaloneSign(t *testing.T) { manifestPath := "fixtures/image.manifest.json" dockerReference := "testing/manifest" - t.Setenv("GNUPGHOME", "fixtures") // Invalid command-line arguments for _, args := range [][]string{ @@ -87,9 +87,6 @@ func TestStandaloneSign(t *testing.T) { require.NoError(t, err) manifest, err := os.ReadFile(manifestPath) require.NoError(t, err) - mech, err = signature.NewGPGSigningMechanism() - require.NoError(t, err) - defer mech.Close() verified, err := signature.VerifyDockerManifestSignature(sig, manifest, dockerReference, mech, fixturesTestKeyFingerprint) require.NoError(t, err) assert.Equal(t, dockerReference, verified.DockerReference) diff --git a/integration/copy_test.go b/integration/copy_test.go index 4eb5eb8d..75da3d78 100644 --- a/integration/copy_test.go +++ b/integration/copy_test.go @@ -745,7 +745,7 @@ func (s *copySuite) TestCopyOCIRoundTrip() { // --sign-by and --policy copy, primarily using atomic: func (s *copySuite) TestCopySignatures() { t := s.T() - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { // FIXME? Test that verification and policy enforcement works, using signatures from fixtures @@ -801,7 +801,7 @@ func (s *copySuite) TestCopySignatures() { // --policy copy for dir: sources func (s *copySuite) TestCopyDirSignatures() { t := s.T() - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { // FIXME? Test that verification and policy enforcement works, using signatures from fixtures @@ -902,7 +902,7 @@ func findRegularFiles(t *testing.T, root string) []string { // --sign-by and policy use for docker: with lookaside func (s *copySuite) TestCopyDockerLookaside() { t := s.T() - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { // FIXME? Test that verification and policy enforcement works, using signatures from fixtures @@ -971,7 +971,7 @@ func (s *copySuite) TestCopyDockerLookaside() { // atomic: and docker: X-Registry-Supports-Signatures works and interoperates func (s *copySuite) TestCopyAtomicExtension() { t := s.T() - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { // FIXME? Test that the reading/writing works using signatures from fixtures @@ -1031,7 +1031,7 @@ func (s *copySuite) TestCopyVerifyingMirroredSignatures() { t := s.T() const regPrefix = "docker://localhost:5006/myns/mirroring-" - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { // FIXME? Test that verification and policy enforcement works, using signatures from fixtures diff --git a/integration/signing_test.go b/integration/signing_test.go index 4eff6afe..50e8bb39 100644 --- a/integration/signing_test.go +++ b/integration/signing_test.go @@ -57,7 +57,7 @@ func (s *signingSuite) SetupSuite() { func (s *signingSuite) TestSignVerifySmoke() { t := s.T() - mech, _, err := signature.NewEphemeralGPGSigningMechanism([]byte{}) + mech, err := signature.NewGPGSigningMechanism() require.NoError(t, err) defer mech.Close() if err := mech.SupportsSigning(); err != nil { // FIXME? Test that verification and policy enforcement works, using signatures from fixtures