github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-07-01 09:02:25 +00:00
Code Issues Projects Releases Wiki Activity

Clarify control flow when handling the tags list

Browse Source 
Don't run the the "tags specified" loop when
tags should be discovered.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This commit is contained in:
Miloslav Trmač 2020-05-22 01:15:14 +02:00 committed by Valentin Rothberg
parent 677c29bf24
commit 0ae9db5dd6
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
cmd/skopeo/sync.go
View File

@ -280,21 +280,21 @@ func imagesToCopyFromRegistry(registryName string, cfg registrySyncConfig, sourc
}).Info("Processing repo") }).Info("Processing repo")
var sourceReferences []types.ImageReference var sourceReferences []types.ImageReference
for _, tag := range tags { if len(tags) != 0 {
source := fmt.Sprintf("%s:%s", repoName, tag) for _, tag := range tags {
source := fmt.Sprintf("%s:%s", repoName, tag)
imageRef, err := docker.ParseReference(source) imageRef, err := docker.ParseReference(source)
if err != nil { if err != nil {
logrus.WithFields(logrus.Fields{ logrus.WithFields(logrus.Fields{
"tag": source, "tag": source,
}).Error("Error processing tag, skipping") }).Error("Error processing tag, skipping")
logrus.Errorf("Error getting image reference: %s", err) logrus.Errorf("Error getting image reference: %s", err)
continue continue
}
sourceReferences = append(sourceReferences, imageRef)
} }
sourceReferences = append(sourceReferences, imageRef) } else { // len(tags) == 0
}
if len(tags) == 0 {
logrus.WithFields(logrus.Fields{ logrus.WithFields(logrus.Fields{
"repo": imageName, "repo": imageName,
"registry": registryName, "registry": registryName,