From 702165af4629360c5cd4ffaa2caa552b1508c1b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= Date: Wed, 8 Apr 2020 14:20:28 +0200 Subject: [PATCH] Fix (make vendor) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit (export a=b command args) does not run (command args) with a=b, it sets $a to b, and marks variables $a $command $args as exported, i.e. (command args) is not run. So, before https://github.com/containers/skopeo/pull/888 we were not actually running (go mod tidy), and now we are not running (go mod vendor). Just use $(GO), which already sets GO111MODULE=on, without the extra export. Signed-off-by: Miloslav Trmač --- Makefile | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 7ef92543..b16b2c3c 100644 --- a/Makefile +++ b/Makefile @@ -184,10 +184,9 @@ test-unit-local: $(GPGME_ENV) $(GO) test $(MOD_VENDOR) -tags "$(BUILDTAGS)" $$($(GO) list $(MOD_VENDOR) -tags "$(BUILDTAGS)" -e ./... | grep -v '^github\.com/containers/skopeo/\(integration\|vendor/.*\)$$') vendor: - export GO111MODULE=on \ - $(GO) mod vendor && \ - $(GO) mod tidy && \ - $(GO) mod verify + $(GO) mod vendor + $(GO) mod tidy + $(GO) mod verify vendor-in-container: podman run --privileged --rm --env HOME=/root -v `pwd`:/src -w /src docker.io/library/golang:1.13 make vendor