github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-05-06 15:06:27 +00:00
Code Issues Projects Releases Wiki Activity

re-enable and fix failing tests

Browse Source 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
This commit is contained in:
Antonio Murdaca 2016-02-02 13:51:10 +01:00
parent 143ff7165d
commit 3de433ea4a
1 changed files with 16 additions and 24 deletions

40
integration/check_test.go
View File

@ -81,31 +81,23 @@ func (s *SkopeoSuite) TestVersion(c *check.C) {
}
}
//func (s *SkopeoSuite) TestCanAuthToPrivateRegistryV2WithoutDockerCfg(c *check.C) {
//out, err := exec.Command(skopeoBinary, "--docker-cfg=''", "--username="+s.regV2WithAuth.username, "--password="+s.regV2WithAuth.password, fmt.Sprintf("%s/busybox:latest", s.regV2WithAuth.url)).CombinedOutput()
//c.Assert(err, check.NotNil, check.Commentf(string(out)))
//wanted := "falling back to --username and --password if needed"
//if !strings.Contains(string(out), wanted) {
//c.Fatalf("wanted %s, got %s", wanted, string(out))
//}
//wanted = "Error: image busybox not found"
//if !strings.Contains(string(out), wanted) {
//c.Fatalf("wanted %s, got %s", wanted, string(out))
//}
//}
func (s *SkopeoSuite) TestCanAuthToPrivateRegistryV2WithoutDockerCfg(c *check.C) {
out, err := exec.Command(skopeoBinary, "--docker-cfg=''", "--username="+s.regV2WithAuth.username, "--password="+s.regV2WithAuth.password, fmt.Sprintf("%s/busybox:latest", s.regV2WithAuth.url)).CombinedOutput()
c.Assert(err, check.NotNil, check.Commentf(string(out)))
wanted := "Error: image busybox not found"
if !strings.Contains(string(out), wanted) {
c.Fatalf("wanted %s, got %s", wanted, string(out))
}
}
//func (s *SkopeoSuite) TestNeedAuthToPrivateRegistryV2WithoutDockerCfg(c *check.C) {
//out, err := exec.Command(skopeoBinary, "--docker-cfg=''", fmt.Sprintf("%s/busybox:latest", s.regV2WithAuth.url)).CombinedOutput()
//c.Assert(err, check.NotNil, check.Commentf(string(out)))
//wanted := "falling back to --username and --password if needed"
//if !strings.Contains(string(out), wanted) {
//c.Fatalf("wanted %s, got %s", wanted, string(out))
//}
//wanted = "no basic auth credentials"
//if !strings.Contains(string(out), wanted) {
//c.Fatalf("wanted %s, got %s", wanted, string(out))
//}
//}
func (s *SkopeoSuite) TestNeedAuthToPrivateRegistryV2WithoutDockerCfg(c *check.C) {
out, err := exec.Command(skopeoBinary, "--docker-cfg=''", fmt.Sprintf("%s/busybox:latest", s.regV2WithAuth.url)).CombinedOutput()
c.Assert(err, check.NotNil, check.Commentf(string(out)))
wanted := "no basic auth credentials"
if !strings.Contains(string(out), wanted) {
c.Fatalf("wanted %s, got %s", wanted, string(out))
}
}
// TODO(runcom): as soon as we can push to registries ensure you can inspect here
// not just get image not found :)