From 7ace4265fb5936f57b6e030a4533502ee853db9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= Date: Sat, 10 Jul 2021 11:33:03 +0200 Subject: [PATCH] Fix TestDockerRepositoryReferenceParser MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Don't ignore errors, and don't even skip test cases on errors. Signed-off-by: Miloslav Trmač --- cmd/skopeo/list_tags_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/skopeo/list_tags_test.go b/cmd/skopeo/list_tags_test.go index 5d5ce17b..f0734eb3 100644 --- a/cmd/skopeo/list_tags_test.go +++ b/cmd/skopeo/list_tags_test.go @@ -5,6 +5,7 @@ import ( "github.com/containers/image/v5/transports/alltransports" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) // Tests the kinds of inputs allowed and expected to the command @@ -17,10 +18,10 @@ func TestDockerRepositoryReferenceParser(t *testing.T) { } { ref, err := parseDockerRepositoryReference(test[0]) + require.NoError(t, err) expected, err := alltransports.ParseImageName(test[0]) - if assert.NoError(t, err, "Could not parse, got error on %v", test[0]) { - assert.Equal(t, expected.DockerReference().Name(), ref.DockerReference().Name(), "Mismatched parse result for input %v", test[0]) - } + require.NoError(t, err) + assert.Equal(t, expected.DockerReference().Name(), ref.DockerReference().Name(), "Mismatched parse result for input %v", test[0]) } for _, test := range [][]string{