github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-08-01 23:07:51 +00:00
Code Issues Projects Releases Wiki Activity

Fix error handling on invalid regex

Browse Source 
Say that the regex is the cause, include it in the error message,
and don't continue as if the compilation succeeded.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This commit is contained in:
Miloslav Trmač 2020-05-22 03:36:42 +02:00 committed by Valentin Rothberg
parent c103d65284
commit 8b4b954332
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/skopeo/sync.go
View File

@ -344,8 +344,11 @@ func imagesToCopyFromRegistry(registryName string, cfg registrySyncConfig, sourc
tagReg, err := regexp.Compile(tagRegex) tagReg, err := regexp.Compile(tagRegex)
if err != nil { if err != nil {
repoLogger.Error("Error processing repo, skipping") repoLogger.WithFields(logrus.Fields{
"regex": tagRegex,
}).Error("Error parsing regex, skipping")
logrus.Error(err) logrus.Error(err)
continue
} }
repoLogger.Info("Querying registry for image tags") repoLogger.Info("Querying registry for image tags")