From 6db88724069caed9466547fd594fa56a9ae89807 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= Date: Wed, 11 May 2016 17:36:02 +0200 Subject: [PATCH] =?UTF-8?q?Don=E2=80=98t=20write=20the=20mainfest=20digest?= =?UTF-8?q?=20on=20stdout=20in=20(skopeo=20copy)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The dir: source type does not return the value, the value is untrusted/not validated, and it is not at all clear why we should print it in the first place. --- cmd/skopeo/copy.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/skopeo/copy.go b/cmd/skopeo/copy.go index bd66b551..5ef4875a 100644 --- a/cmd/skopeo/copy.go +++ b/cmd/skopeo/copy.go @@ -2,7 +2,6 @@ package main import ( "encoding/json" - "fmt" "github.com/Sirupsen/logrus" "github.com/codegangsta/cli" @@ -41,11 +40,10 @@ func copyHandler(context *cli.Context) { } signBy := context.String("sign-by") - manifest, digest, err := src.GetManifest() + manifest, _, err := src.GetManifest() if err != nil { logrus.Fatalf("Error reading manifest: %s", err.Error()) } - fmt.Printf("Canonical manifest digest: %s\n", digest) layers, err := manifestLayers(manifest) if err != nil {