github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-07-21 01:49:58 +00:00
Code Issues Projects Releases Wiki Activity

Don't critically fail on a 403 when listing tags

Browse Source 
Per a report in https://github.com/containers/skopeo/issues/726 ,
it can happen if the user is not allowed the ListImages action
on AWS ECR.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This commit is contained in:
Miloslav Trmač 2019-10-09 00:19:53 +02:00
parent 75b7d1e2af
commit cd8c0085b1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/skopeo/inspect.go
View File

@ -11,7 +11,7 @@ import (
"github.com/containers/image/v5/image" "github.com/containers/image/v5/image"
"github.com/containers/image/v5/manifest" "github.com/containers/image/v5/manifest"
"github.com/containers/image/v5/transports" "github.com/containers/image/v5/transports"
"github.com/opencontainers/go-digest" digest "github.com/opencontainers/go-digest"
"github.com/pkg/errors" "github.com/pkg/errors"
"github.com/sirupsen/logrus" "github.com/sirupsen/logrus"
"github.com/urfave/cli" "github.com/urfave/cli"
@ -177,7 +177,9 @@ func (opts *inspectOptions) run(args []string, stdout io.Writer) (retErr error)
// some registries may decide to block the "list all tags" endpoint // some registries may decide to block the "list all tags" endpoint
// gracefully allow the inspect to continue in this case. Currently // gracefully allow the inspect to continue in this case. Currently
// the IBM Bluemix container registry has this restriction. // the IBM Bluemix container registry has this restriction.
if !strings.Contains(err.Error(), "401") { // In addition, AWS ECR rejects it with 403 (Forbidden) if the "ecr:ListImages"
// action is not allowed.
if !strings.Contains(err.Error(), "401") && !strings.Contains(err.Error(), "403") {
return fmt.Errorf("Error determining repository tags: %v", err) return fmt.Errorf("Error determining repository tags: %v", err)
} }
logrus.Warnf("Registry disallows tag list retrieval; skipping") logrus.Warnf("Registry disallows tag list retrieval; skipping")