add basic test infrastructure

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

integration/check_test.go

@@ -0,0 +1,123 @@
+package main
+
+import (
+	"fmt"
+	"os/exec"
+	"strings"
+	"testing"
+
+	"github.com/go-check/check"
+)
+
+const (
+	privateRegistryURL0 = "127.0.0.1:5000"
+	privateRegistryURL1 = "127.0.0.1:5001"
+	privateRegistryURL2 = "127.0.0.1:5002"
+	privateRegistryURL3 = "127.0.0.1:5003"
+	privateRegistryURL4 = "127.0.0.1:5004"
+
+	skopeoBinary = "skopeo"
+)
+
+func Test(t *testing.T) {
+	check.TestingT(t)
+}
+
+func init() {
+	check.Suite(&SkopeoSuite{})
+}
+
+type SkopeoSuite struct {
+	regV1         *testRegistryV1
+	regV2         *testRegistryV2
+	regV2Shema1   *testRegistryV2
+	regV1WithAuth *testRegistryV1
+	regV2WithAuth *testRegistryV2
+}
+
+func (s *SkopeoSuite) SetUpSuite(c *check.C) {
+
+}
+
+func (s *SkopeoSuite) TearDownSuite(c *check.C) {
+
+}
+
+func (s *SkopeoSuite) SetUpTest(c *check.C) {
+	_, err := exec.LookPath(skopeoBinary)
+	c.Assert(err, check.IsNil)
+
+	s.regV1 = setupRegistryV1At(c, privateRegistryURL0, false) // not used
+	s.regV2 = setupRegistryV2At(c, privateRegistryURL1, false, false)
+	s.regV2Shema1 = setupRegistryV2At(c, privateRegistryURL2, false, true)
+	s.regV1WithAuth = setupRegistryV1At(c, privateRegistryURL3, true) // not used
+	s.regV2WithAuth = setupRegistryV2At(c, privateRegistryURL4, true, false)
+}
+
+func (s *SkopeoSuite) TearDownTest(c *check.C) {
+	// not checking V1 registries now...
+	if s.regV2 != nil {
+		s.regV2.Close()
+	}
+	if s.regV2Shema1 != nil {
+		s.regV2Shema1.Close()
+	}
+	if s.regV2WithAuth != nil {
+		//cmd := exec.Command("docker", "logout", s.regV2WithAuth)
+		//c.Assert(cmd.Run(), check.IsNil)
+		s.regV2WithAuth.Close()
+	}
+}
+
+// TODO like dockerCmd but much easier, just out,err
+//func skopeoCmd()
+
+func (s *SkopeoSuite) TestVersion(c *check.C) {
+	out, err := exec.Command(skopeoBinary, "--version").CombinedOutput()
+	c.Assert(err, check.IsNil, check.Commentf(string(out)))
+	wanted := skopeoBinary + " version "
+	if !strings.Contains(string(out), wanted) {
+		c.Fatalf("wanted %s, got %s", wanted, string(out))
+	}
+}
+
+func (s *SkopeoSuite) TestCanAuthToPrivateRegistryV2WithoutDockerCfg(c *check.C) {
+	out, err := exec.Command(skopeoBinary, "--docker-cfg=''", "--username="+s.regV2WithAuth.username, "--password="+s.regV2WithAuth.password, fmt.Sprintf("%s/busybox:latest", s.regV2WithAuth.url)).CombinedOutput()
+	c.Assert(err, check.NotNil, check.Commentf(string(out)))
+	wanted := "falling back to --username and --password if needed"
+	if !strings.Contains(string(out), wanted) {
+		c.Fatalf("wanted %s, got %s", wanted, string(out))
+	}
+	wanted = "Error: image busybox not found"
+	if !strings.Contains(string(out), wanted) {
+		c.Fatalf("wanted %s, got %s", wanted, string(out))
+	}
+}
+
+func (s *SkopeoSuite) TestNeedAuthToPrivateRegistryV2WithoutDockerCfg(c *check.C) {
+	out, err := exec.Command(skopeoBinary, "--docker-cfg=''", fmt.Sprintf("%s/busybox:latest", s.regV2WithAuth.url)).CombinedOutput()
+	c.Assert(err, check.NotNil, check.Commentf(string(out)))
+	wanted := "falling back to --username and --password if needed"
+	if !strings.Contains(string(out), wanted) {
+		c.Fatalf("wanted %s, got %s", wanted, string(out))
+	}
+	wanted = "no basic auth credentials"
+	if !strings.Contains(string(out), wanted) {
+		c.Fatalf("wanted %s, got %s", wanted, string(out))
+	}
+}
+
+// TODO(runcom): as soon as we can push to registries ensure you can inspect here
+// not just get image not found :)
+func (s *SkopeoSuite) TestNoNeedAuthToPrivateRegistryV2ImageNotFound(c *check.C) {
+	out, err := exec.Command(skopeoBinary, fmt.Sprintf("%s/busybox:latest", s.regV2.url)).CombinedOutput()
+	c.Assert(err, check.NotNil, check.Commentf(string(out)))
+	wanted := "Error: image busybox not found"
+	if !strings.Contains(string(out), wanted) {
+		c.Fatalf("wanted %s, got %s", wanted, string(out))
+	}
+	wanted = "no basic auth credentials"
+	if strings.Contains(string(out), wanted) {
+		c.Fatalf("not wanted %s, got %s", wanted, string(out))
+	}
+}

integration/registry.go

@@ -0,0 +1,136 @@
+package main
+
+import (
+	"fmt"
+	"io/ioutil"
+	"net/http"
+	"os"
+	"os/exec"
+	"path/filepath"
+	"time"
+
+	"github.com/go-check/check"
+)
+
+const (
+	binaryV2        = "registry-v2"
+	binaryV2Schema1 = "registry-v2-schema1"
+)
+
+type testRegistryV1 struct {
+}
+
+func setupRegistryV1At(c *check.C, url string, auth bool) *testRegistryV1 {
+	return &testRegistryV1{}
+}
+
+type testRegistryV2 struct {
+	cmd      *exec.Cmd
+	url      string
+	dir      string
+	username string
+	password string
+	email    string
+}
+
+func setupRegistryV2At(c *check.C, url string, auth, schema1 bool) *testRegistryV2 {
+	reg, err := newTestRegistryV2At(c, url, auth, schema1)
+	c.Assert(err, check.IsNil)
+
+	// Wait for registry to be ready to serve requests.
+	for i := 0; i != 5; i++ {
+		if err = reg.Ping(); err == nil {
+			break
+		}
+		time.Sleep(100 * time.Millisecond)
+	}
+
+	if err != nil {
+		c.Fatal("Timeout waiting for test registry to become available")
+	}
+	return reg
+}
+
+func newTestRegistryV2At(c *check.C, url string, auth, schema1 bool) (*testRegistryV2, error) {
+	tmp, err := ioutil.TempDir("", "registry-test-")
+	if err != nil {
+		return nil, err
+	}
+	template := `version: 0.1
+loglevel: debug
+storage:
+    filesystem:
+        rootdirectory: %s
+http:
+    addr: %s
+%s`
+	var (
+		htpasswd string
+		username string
+		password string
+		email    string
+	)
+	if auth {
+		htpasswdPath := filepath.Join(tmp, "htpasswd")
+		userpasswd := "testuser:$2y$05$sBsSqk0OpSD1uTZkHXc4FeJ0Z70wLQdAX/82UiHuQOKbNbBrzs63m"
+		username = "testuser"
+		password = "testpassword"
+		email = "test@test.org"
+		if err := ioutil.WriteFile(htpasswdPath, []byte(userpasswd), os.FileMode(0644)); err != nil {
+			return nil, err
+		}
+		htpasswd = fmt.Sprintf(`auth:
+    htpasswd:
+        realm: basic-realm
+        path: %s
+`, htpasswdPath)
+	}
+	confPath := filepath.Join(tmp, "config.yaml")
+	config, err := os.Create(confPath)
+	if err != nil {
+		return nil, err
+	}
+	if _, err := fmt.Fprintf(config, template, tmp, url, htpasswd); err != nil {
+		os.RemoveAll(tmp)
+		return nil, err
+	}
+
+	binary := binaryV2
+	if schema1 {
+		binary = binaryV2Schema1
+	}
+
+	cmd := exec.Command(binary, confPath)
+	if err := cmd.Start(); err != nil {
+		os.RemoveAll(tmp)
+		if os.IsNotExist(err) {
+			c.Skip(err.Error())
+		}
+		return nil, err
+	}
+	return &testRegistryV2{
+		cmd:      cmd,
+		url:      url,
+		dir:      tmp,
+		username: username,
+		password: password,
+		email:    email,
+	}, nil
+}
+
+func (t *testRegistryV2) Ping() error {
+	// We always ping through HTTP for our test registry.
+	resp, err := http.Get(fmt.Sprintf("http://%s/v2/", t.url))
+	if err != nil {
+		return err
+	}
+	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusUnauthorized {
+		return fmt.Errorf("registry ping replied with an unexpected status code %d", resp.StatusCode)
+	}
+	return nil
+}
+
+func (t *testRegistryV2) Close() {
+	t.cmd.Process.Kill()
+	os.RemoveAll(t.dir)
+}

integration/test.sh

@@ -0,0 +1,18 @@
+#!/bin/sh
+
+# TODO(runcom): we need docker somehow in container to push/pull to registries
+#command -v docker >/dev/null 2>&1 || { echo >&2 "Docker is required but it's not installed. Aborting."; exit 1;  }
+
+# TODO(runcom): this can be done also with ensure-frozen-images - see docker/docker
+#docker pull busybox:latest >/dev/null 2>&1 || { echo >&2 "docker pull busybox:latest failed. Aborting." exit 1; }
+
+make binary
+make install-binary
+export GO15VENDOREXPERIMENT=1
+
+echo ""
+echo ""
+echo "Testing..."
+echo ""
+
+cd integration/ && go test -test.timeout=10m -check.v