github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-09-03 15:46:42 +00:00
Code Issues Projects Releases Wiki Activity

Reorganize the "list tags failed" logic in inspect.go a bit

Browse Source 
... to allow adding more cases.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This commit is contained in:
Miloslav Trmač
2022-09-06 22:25:45 +02:00
parent c476d62671
commit ea9aa68b0f
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/skopeo/inspect.go
View File

@@ -205,9 +205,13 @@ func (opts *inspectOptions) run(args []string, stdout io.Writer) (retErr error)
if err != nil { if err != nil {
// Some registries may decide to block the "list all tags" endpoint; // Some registries may decide to block the "list all tags" endpoint;
// gracefully allow the inspect to continue in this case: // gracefully allow the inspect to continue in this case:
fatalFailure := true
// - AWS ECR rejects it with 403 (Forbidden) if the "ecr:ListImages" // - AWS ECR rejects it with 403 (Forbidden) if the "ecr:ListImages"
// action is not allowed. // action is not allowed.
if !strings.Contains(err.Error(), "403") { if strings.Contains(err.Error(), "403") {
fatalFailure = false
}
if fatalFailure {
return fmt.Errorf("Error determining repository tags: %w", err) return fmt.Errorf("Error determining repository tags: %w", err)
} }
logrus.Warnf("Registry disallows tag list retrieval; skipping") logrus.Warnf("Registry disallows tag list retrieval; skipping")