github/skopeo
1
0
Fork 0
mirror of https://github.com/containers/skopeo.git synced 2025-09-07 09:40:55 +00:00
Code Issues Projects Releases Wiki Activity

proxy_test: Test GetConfig

Browse Source 
Now that we have a test suite, let's use it more.

Signed-off-by: Colin Walters <walters@verbum.org>
This commit is contained in:
Colin Walters
2021-11-08 09:45:24 -05:00
parent 2bb6f27d13
commit fa86297c36
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
integration/proxy_test.go
View File

@@ -14,6 +14,7 @@ import (
"gopkg.in/check.v1" "gopkg.in/check.v1"
"github.com/containers/image/v5/manifest" "github.com/containers/image/v5/manifest"
imgspecv1 "github.com/opencontainers/image-spec/specs-go/v1"
) )
// This image is known to be x86_64 only right now // This image is known to be x86_64 only right now
@@ -230,7 +231,7 @@ type byteFetch struct {
err error err error
} }
func runTestGetManifest(p *proxy, img string) error { func runTestGetManifestAndConfig(p *proxy, img string) error {
v, err := p.callNoFd("OpenImage", []interface{}{knownNotManifestListedImage_x8664}) v, err := p.callNoFd("OpenImage", []interface{}{knownNotManifestListedImage_x8664})
if err != nil { if err != nil {
return err return err
@@ -251,6 +252,21 @@ func runTestGetManifest(p *proxy, img string) error {
return err return err
} }
v, configBytes, err := p.callReadAllBytes("GetConfig", []interface{}{imgid})
if err != nil {
return err
}
var config imgspecv1.ImageConfig
err = json.Unmarshal(configBytes, &config)
if err != nil {
return err
}
// Validate that the config seems sane
if len(config.Cmd) == 0 && len(config.Entrypoint) == 0 {
return fmt.Errorf("No CMD or ENTRYPOINT set")
}
_, err = p.callNoFd("CloseImage", []interface{}{imgid}) _, err = p.callNoFd("CloseImage", []interface{}{imgid})
return nil return nil
@@ -260,13 +276,13 @@ func (s *ProxySuite) TestProxy(c *check.C) {
p, err := newProxy() p, err := newProxy()
c.Assert(err, check.IsNil) c.Assert(err, check.IsNil)
err = runTestGetManifest(p, knownNotManifestListedImage_x8664) err = runTestGetManifestAndConfig(p, knownNotManifestListedImage_x8664)
if err != nil { if err != nil {
err = fmt.Errorf("Testing image %s: %v", knownNotManifestListedImage_x8664, err) err = fmt.Errorf("Testing image %s: %v", knownNotManifestListedImage_x8664, err)
} }
c.Assert(err, check.IsNil) c.Assert(err, check.IsNil)
err = runTestGetManifest(p, knownListImage) err = runTestGetManifestAndConfig(p, knownListImage)
if err != nil { if err != nil {
err = fmt.Errorf("Testing image %s: %v", knownListImage, err) err = fmt.Errorf("Testing image %s: %v", knownListImage, err)
} }