44 Commits

Author SHA1 Message Date
Daniel J Walsh
b75bf0a5b3 Currently buildah run is not handling command options correctly
This patch will allow commands like

buildah run $ctr ls -lZ /

To work correctly.

Need to update vendor of urfave cli.

Also changed all commands to no longer accept global options after the COMMAND.
Single boolean options can now be passed together.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #493
Approved by: rhatdan
2018-02-27 12:08:45 +00:00
umohnani8
669ffddd99 Vendor in latest containers/image
Fixes the naming issue of blobs and config for the dir transport
by removing the .tar extension

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #489
Approved by: rhatdan
2018-02-22 18:57:31 +00:00
Daniel J Walsh
5ca91c0eb7 Vendor in latest containers/storage
This fixes a large SELinux bug.  Currently if you do the following
commands

ctr=$(buildah from scratch)
mnt=$(buildah mount $ctr)
dnf install --installroot=$mnt httpd
buildah run $ctr touch /test

The last command fails.  The reason for this is the SELinux labels are getting applied
to the mount point, since it was not being mounted as an overlay file system.

Containers/storage was updated to always mount an overlay even if the lower layer is empty
This then causes the mount point to use a context mount, and changes dnf to not apply
labels.  This change then allows buildah run to create confined containers to run code.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #486
Approved by: TomSweeneyRedHat
2018-02-22 13:55:26 +00:00
umohnani8
b23f145416 Vendor in packages
vendor in profiles from github.com/docker/docker/profiles to support seccomp.
vendor in latest runtime-tools to support bind mounting.

Signed-off-by: umohnani8 <umohnani@redhat.com>

Closes: #477
Approved by: rhatdan
2018-02-19 17:00:29 +00:00
umohnani8
032b56ee8d Vendor in latest containers/image
Adds support for default certs directory to be /etc/containers/certs.d

Signed-off-by: umohnani8 <umohnani@redhat.com>
2018-02-06 17:04:34 -05:00
Daniel J Walsh
6af847dd2a Vendor in latest containers/storage
A patch got merged into containers/storage that makes sure SELinux labels
are appliced when committing to storage.  This prevents a failure condition
which arrises from leaked mount points between the time a container is mounted
and it is committed.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #453
Approved by: TomSweeneyRedHat
2018-02-06 20:26:45 +00:00
Boaz Shuster
4d6c90e902 vendor containers/image to 386d6c33c9d622ed84baf14f4b1ff1be86800ccd
Signed-off-by: Boaz Shuster <bshuster@redhat.com>

Closes: #393
Approved by: rhatdan
2018-01-16 16:44:34 +00:00
Daniel J Walsh
01f8c7afee Remove chrootuser handling and use libpod/pkg
I have made a subpackage of libpod to handle chrootuser,
using the user code from buildah.

This patch removes user handling from buildah and uses
projectatomic/libpod/pkg/chrootuser

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #377
Approved by: nalind
2018-01-03 15:36:10 +00:00
Nalin Dahyabhai
0705787a07 Bump containers/image
Bump containers/image to 4fdf9c9b8a1e014705581ff77df6446e67a8318d.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #366
Approved by: nalind
2017-12-15 17:54:40 +00:00
Nalin Dahyabhai
47ac96155f Use configured registries to resolve image names
When locating an image for pulling, inspection, or pushing, if we're
given an image name that doesn't include a domain/registry, try building
a set of candidate names using the configured registries as domains, and
then pull/inspect/push using the first of those names that works.

If a name that we're given corresponds to a prefix of the ID of a local
image, skip completion and use the ID directly instead.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #360
Approved by: rhatdan
2017-12-14 22:21:16 +00:00
Nalin Dahyabhai
544e63de42 Bump containers/image and containers/storage
Update containers/image and containers/storage to current master
(17449738f2bb4c6375c20dcdcfe2a6cccf03f312 and
0d32dfce498e06c132c60dac945081bf44c22464, respectively).

Also updates github.com/docker/docker, golang.org/x/sys, and
golang.org/x/text.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #187
Approved by: rhatdan
2017-12-14 20:57:13 +00:00
Urvashi Mohnani
5ececfad2c Vendor in latest container/image
Adds support for converting manifest types when using the dir transport

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>

Closes: #321
Approved by: rhatdan
2017-11-15 13:38:28 +00:00
Nalin Dahyabhai
f7dc659e52 Bump github.com/vbatts/tar-split
Update github.com/vbatts/tar-split to v0.10.2 and pin that version
instead of master, to pick up https://github.com/vbatts/tar-split/pull/42

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #318
Approved by: rhatdan
2017-11-08 17:36:54 +00:00
Daniel J Walsh
966f32b2ac Add proper SELinux labeling to buildah run
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #294
Approved by: nalind
2017-11-07 22:40:29 +00:00
Daniel J Walsh
5aec4fe722 Vendor in latest code from containers/storage
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #288
Approved by: rhatdan
2017-10-13 19:53:54 +00:00
Daniel J Walsh
8ecefa978c Vendor in changes to support sirupsen/logrus
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2017-10-10 17:30:11 +00:00
Nalin Dahyabhai
be5bcd549d Bump containers/storage and containers/image
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #227
Approved by: rhatdan
2017-07-28 12:10:46 +00:00
Dan Walsh
b9b2a8a7ef Vendor in latest containers/image and bump to version 0.3
OCI 1.0 Image specification is now released so we want to bump
buildah version to support 1.0 images.

Bump to version 0.3

Signed-off-by: Dan Walsh <dwalsh@redhat.com>

Closes: #203
Approved by: rhatdan
2017-07-20 20:23:32 +00:00
Nalin Dahyabhai
a500e22104 Update image-spec and runtime-spec to v1.0.0
Update to just-released versions of image-spec and runtime-spec, and the
latest version of runtime-tools.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #201
Approved by: rhatdan
2017-07-20 18:38:19 +00:00
Nalin Dahyabhai
be2d536f52 Bump containers/storage and containers/image
Bump containers/storage and containers/image, and pin them to their
current versions.  This requires that we update image-spec to rc6 and
add github.com/ostreedev/ostree-go, which adds build-time requirements
on glib2-devel and ostree-devel.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #174
Approved by: rhatdan
2017-06-28 21:05:58 +00:00
Dan Walsh
04a9fceaae Vendor in latest container/storage
container/storage now supports remote shares and having a configuration
file.  We need to merge this to demonstrate using buildah with nfs shares.

Signed-off-by: Dan Walsh <dwalsh@redhat.com>

Closes: #145
Approved by: nalind
2017-06-14 13:16:37 +00:00
Dan Walsh
e1876db308 Vendor in latest container/storage
container/storage now supports remote shares and having a configuration
file.  We need to merge this to demonstrate using buildah with nfs shares.

Signed-off-by: Dan Walsh <dwalsh@redhat.com>

Closes: #140
Approved by: nalind
2017-06-09 13:57:06 +00:00
Dan Walsh
95c2a2d99c Vendor in containers/storage and containers/image
Signed-off-by: Dan Walsh <dwalsh@redhat.com>

Closes: #103
Approved by: nalind
2017-05-17 21:19:24 +00:00
Nalin Dahyabhai
a930251d21 Bump github.com/mattn/go-shellwords
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #87
Approved by: nalind
2017-04-27 18:21:13 +00:00
Nalin Dahyabhai
f4e6ca7233 Bump github.com/containers/image
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #87
Approved by: nalind
2017-04-27 18:21:13 +00:00
Nalin Dahyabhai
d2e102d910 Bump github.com/docker/distribution
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #87
Approved by: nalind
2017-04-27 18:21:13 +00:00
Nalin Dahyabhai
6c84328107 Bump github.com/containers/storage
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #87
Approved by: nalind
2017-04-27 18:21:13 +00:00
Nalin Dahyabhai
406a8b9057 Updated vendored deps
Re-vendor github.com/docker/docker and github.com/opencontainers/runc,
which we now use less of than we did previously.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:25 +00:00
Nalin Dahyabhai
5c00086866 Bump opencontainers/runtime-spec and runtime-tools
Update the versions of github.com/opencontainers/runtime-spec and
github.com/opencontainers/runtime-tools that we vendor.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:25 +00:00
Nalin Dahyabhai
4a8e4b2c12 Bump fsouza/go-dockerclient
Update the version of github.com/fsouza/go-dockerclient that we vendor,
and pick up its new dependency on github.com/moby/moby.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:25 +00:00
Nalin Dahyabhai
9a6dc67054 Bump and pin github.com/docker/go-connections
Update and pin the version of github.com/docker/go-connections that we
vendor.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:25 +00:00
Nalin Dahyabhai
21c71b634b Bump containers/image and image-spec
Update to the current github.com/containers/image and
github.com/opencontainers/image-spec packages.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:24 +00:00
Nalin Dahyabhai
3ca21d0bc3 Bump containers/storage and pick up its new dep
Update to the current containers/storage and vendor its new dependency
on github.com/tchap/go-patricia.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:24 +00:00
Nalin Dahyabhai
cbfae6b0f6 Bump github.com/docker/docker
Update our version of github.com/docker/docker.  Now that we've got #75
merged, we end up pulling in quite a bit less of it.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #79
Approved by: nalind
2017-04-20 15:38:24 +00:00
Nalin Dahyabhai
a532522624 Vendor openshift/imagebuilder
Vendor openshift/imagebuilder and its dependencies, and pick up new
dependencies on golang.org/x/text and github.com/opencontainers/selinux.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>

Closes: #59
Approved by: rhatdan
2017-04-13 21:42:51 +00:00
Daniel J Walsh
df71b8fe6a Update vendor patches
Closes: #51
Approved by: rhatdan
2017-03-28 19:22:27 +00:00
Nalin Dahyabhai
f33ae08da5 Update vendored dependencies
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-03-22 16:33:24 -04:00
Nalin Dahyabhai
165f985fc3 Update vendored deps to match other vendored deps
Get vendored deps to play with a newer version of the runtime spec.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-02-13 17:21:45 -05:00
Nalin Dahyabhai
b04e523c8d Update vendored dependencies
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-02-13 17:21:45 -05:00
Nalin Dahyabhai
6efaa3d56e Another stab at getting go1.6 builds working
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-02-06 14:58:10 -05:00
Nalin Dahyabhai
084b9e4694 Fixup vendored engine-api for go 1.5
Fix builds against go 1.5.  This should be temporary, since code we
vendor which depends on engine-api should be moving to something else.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-02-06 14:38:56 -05:00
Nalin Dahyabhai
9516d58c56 Start to vendor docker, update other deps
Drop back to a slightly older version of the runtime spec.
Vendor github.com/docker/docker to get type definitions.
Switch to the containers version of storage.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-02-02 18:32:00 -05:00
Nalin Dahyabhai
6e489ae1f0 Add missing github.com/gorilla/context package
The github.com/gorilla/mux package requires github.com/gorilla/context,
so we need to vendor it, too.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-01-28 06:14:18 +01:00
Nalin Dahyabhai
931372925b Include our vendored dependencies
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2017-01-28 05:59:37 +01:00