mirror of
https://github.com/containers/skopeo.git
synced 2026-07-15 06:55:09 +00:00
Default to mounting tmpfs over a container's volume mount points. Add a RunOption for adding mounts to a run container, and use it as the default set, adding any volume mounts and others that don't conflict with them to it before running the container. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
150 lines
3.7 KiB
Go
150 lines
3.7 KiB
Go
package buildah
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
"github.com/containers/storage/pkg/ioutils"
|
|
"github.com/opencontainers/image-spec/specs-go/v1"
|
|
"github.com/opencontainers/runtime-spec/specs-go"
|
|
"github.com/opencontainers/runtime-tools/generate"
|
|
)
|
|
|
|
const (
|
|
// DefaultWorkingDir is used if none was specified.
|
|
DefaultWorkingDir = "/"
|
|
// DefaultRuntime is the default command to use to run the container.
|
|
DefaultRuntime = "runc"
|
|
)
|
|
|
|
// RunOptions can be used to alter how a command is run in the container.
|
|
type RunOptions struct {
|
|
// Hostname is the hostname we set for the running container.
|
|
Hostname string
|
|
// Runtime is the name of the command to run. It should accept the same arguments that runc does.
|
|
Runtime string
|
|
// Args adds global arguments for the runtime.
|
|
Args []string
|
|
// Mounts are additional mount points which we want to provide.
|
|
Mounts []specs.Mount
|
|
}
|
|
|
|
func getExportOptions() generate.ExportOptions {
|
|
return generate.ExportOptions{}
|
|
}
|
|
|
|
// Run runs the specified command in the container's root filesystem.
|
|
func (b *Builder) Run(command []string, options RunOptions) error {
|
|
path, err := ioutil.TempDir(os.TempDir(), Package)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
logrus.Debugf("using %q to hold bundle data", path)
|
|
defer func() {
|
|
if err2 := os.RemoveAll(path); err2 != nil {
|
|
logrus.Errorf("error removing %q: %v", path, err2)
|
|
}
|
|
}()
|
|
config := b.updatedConfig()
|
|
image := v1.Image{}
|
|
err = json.Unmarshal(config, &image)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
user, err := getUser(image.Config.User)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
g := generate.New()
|
|
|
|
if image.OS != "" {
|
|
g.SetPlatformOS(image.OS)
|
|
}
|
|
if image.Architecture != "" {
|
|
g.SetPlatformArch(image.Architecture)
|
|
}
|
|
g.SetProcessUID(user.UID)
|
|
g.SetProcessGID(user.GID)
|
|
for _, envSpec := range image.Config.Env {
|
|
env := strings.SplitN(envSpec, "=", 2)
|
|
if len(env) > 1 {
|
|
g.AddProcessEnv(env[0], env[1])
|
|
}
|
|
}
|
|
if len(command) > 0 {
|
|
g.SetProcessArgs(command)
|
|
} else if len(image.Config.Cmd) != 0 {
|
|
g.SetProcessArgs(image.Config.Cmd)
|
|
} else if len(image.Config.Entrypoint) != 0 {
|
|
g.SetProcessArgs(image.Config.Entrypoint)
|
|
}
|
|
if image.Config.WorkingDir != "" {
|
|
g.SetProcessCwd(image.Config.WorkingDir)
|
|
}
|
|
if options.Hostname != "" {
|
|
g.SetHostname(options.Hostname)
|
|
}
|
|
for volume := range image.Config.Volumes {
|
|
g.AddTmpfsMount(volume, nil)
|
|
}
|
|
mountPoint, err := b.Mount("")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() {
|
|
if err2 := b.Unmount(); err2 != nil {
|
|
logrus.Errorf("error unmounting container: %v", err2)
|
|
}
|
|
}()
|
|
g.SetRootPath(mountPoint)
|
|
g.SetProcessTerminal(true)
|
|
spec := g.Spec()
|
|
if spec.Process.Cwd == "" {
|
|
spec.Process.Cwd = DefaultWorkingDir
|
|
}
|
|
mounts := options.Mounts
|
|
for _, specMount := range spec.Mounts {
|
|
override := false
|
|
for _, mount := range mounts {
|
|
if specMount.Destination == mount.Destination {
|
|
// Already have an override for it, so skip this one.
|
|
override = true
|
|
}
|
|
}
|
|
if !override {
|
|
mounts = append(mounts, specMount)
|
|
}
|
|
}
|
|
spec.Mounts = mounts
|
|
specbytes, err := json.Marshal(spec)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
err = ioutils.AtomicWriteFile(filepath.Join(path, "config.json"), specbytes, 0600)
|
|
if err != nil {
|
|
return fmt.Errorf("error storing runtime configuration: %v", err)
|
|
}
|
|
logrus.Debugf("config = %v", string(specbytes))
|
|
runtime := options.Runtime
|
|
if runtime == "" {
|
|
runtime = DefaultRuntime
|
|
}
|
|
args := append(options.Args, "run", "-b", path, Package+"-"+b.ContainerID)
|
|
cmd := exec.Command(runtime, args...)
|
|
cmd.Dir = mountPoint
|
|
cmd.Stdin = os.Stdin
|
|
cmd.Stdout = os.Stdout
|
|
cmd.Stderr = os.Stderr
|
|
err = cmd.Run()
|
|
if err != nil {
|
|
logrus.Debugf("error running runc %v: %v", spec.Process.Args, err)
|
|
}
|
|
return err
|
|
}
|