github/steve
1
0
Fork 0
mirror of https://github.com/niusmallnan/steve.git synced 2025-09-13 05:20:19 +00:00
Code Issues Projects Releases Wiki Activity

Fix possible context leaks

Browse Source
This commit is contained in:
Darren Shepherd
2020-05-22 15:34:59 -07:00
parent a48c49f660
commit a8e9297258
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/schema/collection.go
View File

@@ -150,6 +150,7 @@ func (c *Collection) startStopTemplate(schemas map[string]*types.APISchema) {
subCtx, cancel := context.WithCancel(c.ctx) subCtx, cancel := context.WithCancel(c.ctx)
if err := template.Start(subCtx); err != nil { if err := template.Start(subCtx); err != nil {
cancel()
logrus.Errorf("failed to start schema template: %s", id) logrus.Errorf("failed to start schema template: %s", id)
continue continue
} }

1
pkg/server/store/proxy/rbac_store.go
View File

@@ -182,6 +182,7 @@ func (r *RBACStore) Watch(apiOp *types.APIRequest, schema *types.APISchema, w ty
} }
ctx, cancel := context.WithCancel(apiOp.Context()) ctx, cancel := context.WithCancel(apiOp.Context())
defer cancel()
apiOp = apiOp.WithContext(ctx) apiOp = apiOp.WithContext(ctx)
eg := errgroup.Group{} eg := errgroup.Group{}