github/steve
1
0
Fork 0
mirror of https://github.com/niusmallnan/steve.git synced 2025-06-26 14:41:35 +00:00
Code Issues Projects Releases Wiki Activity

Don't use slow strings.Compare

Browse Source
This commit is contained in:
Darren Shepherd 2020-03-21 07:49:17 -07:00
parent b78a8b03dd
commit c61e788d6e
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/accesscontrol/policy_rule_index.go
View File

@ -3,7 +3,6 @@ package accesscontrol
import ( import (
"hash" "hash"
"sort" "sort"
"strings"
v1 "github.com/rancher/wrangler-api/pkg/generated/controllers/rbac/v1" v1 "github.com/rancher/wrangler-api/pkg/generated/controllers/rbac/v1"
rbacv1 "k8s.io/api/rbac/v1" rbacv1 "k8s.io/api/rbac/v1"
@ -166,12 +165,7 @@ func (p *policyRuleIndex) getRoleBindings(subjectName string) []*rbacv1.RoleBind
return nil return nil
} }
sort.Slice(result, func(i, j int) bool { sort.Slice(result, func(i, j int) bool {
if i := strings.Compare(result[i].Namespace, result[j].Namespace); i < 0 { return string(result[i].UID) < string(result[j].UID)
return true
} else if i > 0 {
return false
}
return result[i].Name < result[j].Name
}) })
return result return result
} }